* [PATCH v2 0/3] Fix reg ranges for main_pktdma dma-controller node
@ 2024-04-30 10:52 Jayesh Choudhary
2024-04-30 10:52 ` [PATCH v2 1/3] arm64: dts: ti: k3-am62-main: Fix the reg-range for main_pktdma Jayesh Choudhary
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Jayesh Choudhary @ 2024-04-30 10:52 UTC (permalink / raw
To: nm, vigneshr, u-kumar1, bb, devicetree, j-choudhary
Cc: kristo, robh, krzk+dt, conor+dt, linux-kernel, linux-arm-kernel
The dma-controller node 'main_pktdma' has few memory regions with
wrong sizes.
DMASS0_PKTDMA_RINGRT is marked as 4MB region when it is actually a 2MB
region. Similarly, DMASS0_PKTDMA_TCHANRT is marked as 256KB region but
the actual size is 128KB as shown in TRM in the section for Main Memory
Map (Table 2-1)
Fix these region across AM62, AM62A and AM62P (which is also used in
J722S)
TRM:
AM625: <https://www.ti.com/lit/pdf/spruiv7>
AM62A7: <https://www.ti.com/lit/pdf/spruj16>
AM62P: <https://www.ti.com/lit/pdf/spruj83>
J722S: <https://www.ti.com/lit/zip/sprujb3>
Changelog v1->v2:
- Add main_pktdma node name in commit message for more clarity about the
dma-controller and mention the table for memory map in TRM in each patch.
v1 patch:
<https://lore.kernel.org/all/20240405085208.32227-1-j-choudhary@ti.com/>
Jayesh Choudhary (3):
arm64: dts: ti: k3-am62-main: Fix the reg-range for main_pktdma
arm64: dts: ti: k3-am62a-main: Fix the reg-range for main_pktdma
arm64: dts: ti: k3-am62p-main: Fix the reg-range for main_pktdma
arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 4 ++--
arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 4 ++--
arch/arm64/boot/dts/ti/k3-am62p-main.dtsi | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/3] arm64: dts: ti: k3-am62-main: Fix the reg-range for main_pktdma
2024-04-30 10:52 [PATCH v2 0/3] Fix reg ranges for main_pktdma dma-controller node Jayesh Choudhary
@ 2024-04-30 10:52 ` Jayesh Choudhary
2024-04-30 10:52 ` [PATCH v2 2/3] arm64: dts: ti: k3-am62a-main: " Jayesh Choudhary
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Jayesh Choudhary @ 2024-04-30 10:52 UTC (permalink / raw
To: nm, vigneshr, u-kumar1, bb, devicetree, j-choudhary
Cc: kristo, robh, krzk+dt, conor+dt, linux-kernel, linux-arm-kernel
For main_pktdma node, the TX Channel Realtime Register region 'tchanrt'
is 128KB and Ring Realtime Register region 'ringrt' is 2MB as shown in
memory map in the TRM[0] (Table 2-1).
So fix ranges for those register regions.
[0]: <https://www.ti.com/lit/pdf/spruiv7>
Fixes: c37c58fdeb8a ("arm64: dts: ti: k3-am62: Add more peripheral nodes")
Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
---
arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
index 448a59dc53a7..0f2722c4bcc3 100644
--- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
@@ -141,8 +141,8 @@ main_pktdma: dma-controller@485c0000 {
compatible = "ti,am64-dmss-pktdma";
reg = <0x00 0x485c0000 0x00 0x100>,
<0x00 0x4a800000 0x00 0x20000>,
- <0x00 0x4aa00000 0x00 0x40000>,
- <0x00 0x4b800000 0x00 0x400000>,
+ <0x00 0x4aa00000 0x00 0x20000>,
+ <0x00 0x4b800000 0x00 0x200000>,
<0x00 0x485e0000 0x00 0x10000>,
<0x00 0x484a0000 0x00 0x2000>,
<0x00 0x484c0000 0x00 0x2000>,
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 2/3] arm64: dts: ti: k3-am62a-main: Fix the reg-range for main_pktdma
2024-04-30 10:52 [PATCH v2 0/3] Fix reg ranges for main_pktdma dma-controller node Jayesh Choudhary
2024-04-30 10:52 ` [PATCH v2 1/3] arm64: dts: ti: k3-am62-main: Fix the reg-range for main_pktdma Jayesh Choudhary
@ 2024-04-30 10:52 ` Jayesh Choudhary
2024-04-30 10:52 ` [PATCH v2 3/3] arm64: dts: ti: k3-am62p-main: " Jayesh Choudhary
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Jayesh Choudhary @ 2024-04-30 10:52 UTC (permalink / raw
To: nm, vigneshr, u-kumar1, bb, devicetree, j-choudhary
Cc: kristo, robh, krzk+dt, conor+dt, linux-kernel, linux-arm-kernel
For main_pktdma node, the TX Channel Realtime Register region 'tchanrt'
is 128KB and Ring Realtime Register region 'ringrt' is 2MB as shown in
memory map in the TRM[0] (Table 2-1).
So fix ranges for those register regions.
[0]: <https://www.ti.com/lit/pdf/spruj16>
Fixes: 3dad70def7ff ("arm64: dts: ti: k3-am62a-main: Add more peripheral nodes")
Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
---
arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
index bf9c2d9c6439..ce4a2f105630 100644
--- a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
@@ -120,8 +120,8 @@ main_pktdma: dma-controller@485c0000 {
compatible = "ti,am64-dmss-pktdma";
reg = <0x00 0x485c0000 0x00 0x100>,
<0x00 0x4a800000 0x00 0x20000>,
- <0x00 0x4aa00000 0x00 0x40000>,
- <0x00 0x4b800000 0x00 0x400000>,
+ <0x00 0x4aa00000 0x00 0x20000>,
+ <0x00 0x4b800000 0x00 0x200000>,
<0x00 0x485e0000 0x00 0x10000>,
<0x00 0x484a0000 0x00 0x2000>,
<0x00 0x484c0000 0x00 0x2000>,
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 3/3] arm64: dts: ti: k3-am62p-main: Fix the reg-range for main_pktdma
2024-04-30 10:52 [PATCH v2 0/3] Fix reg ranges for main_pktdma dma-controller node Jayesh Choudhary
2024-04-30 10:52 ` [PATCH v2 1/3] arm64: dts: ti: k3-am62-main: Fix the reg-range for main_pktdma Jayesh Choudhary
2024-04-30 10:52 ` [PATCH v2 2/3] arm64: dts: ti: k3-am62a-main: " Jayesh Choudhary
@ 2024-04-30 10:52 ` Jayesh Choudhary
2024-05-02 10:20 ` [PATCH v2 0/3] Fix reg ranges for main_pktdma dma-controller node Kumar, Udit
2024-06-13 6:31 ` Vignesh Raghavendra
4 siblings, 0 replies; 6+ messages in thread
From: Jayesh Choudhary @ 2024-04-30 10:52 UTC (permalink / raw
To: nm, vigneshr, u-kumar1, bb, devicetree, j-choudhary
Cc: kristo, robh, krzk+dt, conor+dt, linux-kernel, linux-arm-kernel
For main_pktdma node, the TX Channel Realtime Register region 'tchanrt'
is 128KB and Ring Realtime Register region 'ringrt' is 2MB as shown in
memory map in the TRM[0] (Table 2-1).
So fix ranges for those register regions.
[0]: <https://www.ti.com/lit/pdf/spruj83>
Fixes: b5080c7c1f7e ("arm64: dts: ti: k3-am62p: Add nodes for more IPs")
Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
---
arch/arm64/boot/dts/ti/k3-am62p-main.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi
index 900d1f9530a2..2b9bc77a0540 100644
--- a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi
@@ -123,8 +123,8 @@ main_pktdma: dma-controller@485c0000 {
compatible = "ti,am64-dmss-pktdma";
reg = <0x00 0x485c0000 0x00 0x100>,
<0x00 0x4a800000 0x00 0x20000>,
- <0x00 0x4aa00000 0x00 0x40000>,
- <0x00 0x4b800000 0x00 0x400000>,
+ <0x00 0x4aa00000 0x00 0x20000>,
+ <0x00 0x4b800000 0x00 0x200000>,
<0x00 0x485e0000 0x00 0x10000>,
<0x00 0x484a0000 0x00 0x2000>,
<0x00 0x484c0000 0x00 0x2000>,
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 0/3] Fix reg ranges for main_pktdma dma-controller node
2024-04-30 10:52 [PATCH v2 0/3] Fix reg ranges for main_pktdma dma-controller node Jayesh Choudhary
` (2 preceding siblings ...)
2024-04-30 10:52 ` [PATCH v2 3/3] arm64: dts: ti: k3-am62p-main: " Jayesh Choudhary
@ 2024-05-02 10:20 ` Kumar, Udit
2024-06-13 6:31 ` Vignesh Raghavendra
4 siblings, 0 replies; 6+ messages in thread
From: Kumar, Udit @ 2024-05-02 10:20 UTC (permalink / raw
To: Jayesh Choudhary, nm, vigneshr, bb, devicetree
Cc: kristo, robh, krzk+dt, conor+dt, linux-kernel, linux-arm-kernel,
u-kumar1
Thanks Jayesh
On 4/30/2024 4:22 PM, Jayesh Choudhary wrote:
> The dma-controller node 'main_pktdma' has few memory regions with
> wrong sizes.
>
> DMASS0_PKTDMA_RINGRT is marked as 4MB region when it is actually a 2MB
> region. Similarly, DMASS0_PKTDMA_TCHANRT is marked as 256KB region but
> the actual size is 128KB as shown in TRM in the section for Main Memory
> Map (Table 2-1)
>
> Fix these region across AM62, AM62A and AM62P (which is also used in
> J722S)
>
> TRM:
For series
Reviewed-by: Udit Kumar <u-kumar1@ti.com>
>
> AM625: <https://www.ti.com/lit/pdf/spruiv7>
> AM62A7: <https://www.ti.com/lit/pdf/spruj16>
> AM62P: <https://www.ti.com/lit/pdf/spruj83>
> J722S: <https://www.ti.com/lit/zip/sprujb3>
>
> Changelog v1->v2:
> - Add main_pktdma node name in commit message for more clarity about the
> dma-controller and mention the table for memory map in TRM in each patch.
>
> v1 patch:
> <https://lore.kernel.org/all/20240405085208.32227-1-j-choudhary@ti.com/>
>
> Jayesh Choudhary (3):
> arm64: dts: ti: k3-am62-main: Fix the reg-range for main_pktdma
> arm64: dts: ti: k3-am62a-main: Fix the reg-range for main_pktdma
> arm64: dts: ti: k3-am62p-main: Fix the reg-range for main_pktdma
>
> arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 4 ++--
> arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 4 ++--
> arch/arm64/boot/dts/ti/k3-am62p-main.dtsi | 4 ++--
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 0/3] Fix reg ranges for main_pktdma dma-controller node
2024-04-30 10:52 [PATCH v2 0/3] Fix reg ranges for main_pktdma dma-controller node Jayesh Choudhary
` (3 preceding siblings ...)
2024-05-02 10:20 ` [PATCH v2 0/3] Fix reg ranges for main_pktdma dma-controller node Kumar, Udit
@ 2024-06-13 6:31 ` Vignesh Raghavendra
4 siblings, 0 replies; 6+ messages in thread
From: Vignesh Raghavendra @ 2024-06-13 6:31 UTC (permalink / raw
To: nm, u-kumar1, bb, devicetree, Jayesh Choudhary
Cc: Vignesh Raghavendra, kristo, robh, krzk+dt, conor+dt,
linux-kernel, linux-arm-kernel
Hi Jayesh Choudhary,
On Tue, 30 Apr 2024 16:22:50 +0530, Jayesh Choudhary wrote:
> The dma-controller node 'main_pktdma' has few memory regions with
> wrong sizes.
>
> DMASS0_PKTDMA_RINGRT is marked as 4MB region when it is actually a 2MB
> region. Similarly, DMASS0_PKTDMA_TCHANRT is marked as 256KB region but
> the actual size is 128KB as shown in TRM in the section for Main Memory
> Map (Table 2-1)
>
> [...]
I have applied the following to branch ti-k3-dts-next on [1].
Thank you!
[1/3] arm64: dts: ti: k3-am62-main: Fix the reg-range for main_pktdma
commit: 6edad223553c7f1680fcaca25ded59eba7c6d82d
[2/3] arm64: dts: ti: k3-am62a-main: Fix the reg-range for main_pktdma
commit: d007a883a61f55b9b195c4c18bbe29de5b802822
[3/3] arm64: dts: ti: k3-am62p-main: Fix the reg-range for main_pktdma
commit: a6e6604c600aeedf9700de4a55255850391bc3fc
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Vignesh
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-06-13 6:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-30 10:52 [PATCH v2 0/3] Fix reg ranges for main_pktdma dma-controller node Jayesh Choudhary
2024-04-30 10:52 ` [PATCH v2 1/3] arm64: dts: ti: k3-am62-main: Fix the reg-range for main_pktdma Jayesh Choudhary
2024-04-30 10:52 ` [PATCH v2 2/3] arm64: dts: ti: k3-am62a-main: " Jayesh Choudhary
2024-04-30 10:52 ` [PATCH v2 3/3] arm64: dts: ti: k3-am62p-main: " Jayesh Choudhary
2024-05-02 10:20 ` [PATCH v2 0/3] Fix reg ranges for main_pktdma dma-controller node Kumar, Udit
2024-06-13 6:31 ` Vignesh Raghavendra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).