From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Rob Herring <robh+dt@kernel.org>
Cc: "Binbin Zhou" <zhoubinbin@loongson.cn>,
"Binbin Zhou" <zhoubb.aaron@gmail.com>,
"Huacai Chen" <chenhuacai@loongson.cn>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Huacai Chen" <chenhuacai@kernel.org>,
loongson-kernel@lists.loongnix.cn, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: pwm: renesas,tpu: Do not require pwm-cells twice
Date: Thu, 9 May 2024 19:29:24 +0200 [thread overview]
Message-ID: <dthqwkvdy7qkkwr6bvvi3mwutuaggnj3xripwa2jvqv4lni5bd@3zlnzotkmmfx> (raw)
In-Reply-To: <CAL_JsqJewzGp5E+O44JgvHu9Q-3PKaXnhjUQbmV7OHfFCEX3Ug@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1710 bytes --]
On Thu, May 09, 2024 at 08:46:14AM -0500, Rob Herring wrote:
> On Tue, May 7, 2024 at 1:54 AM Binbin Zhou <zhoubinbin@loongson.cn> wrote:
> >
> > pwm-cells property is already required by pwm.yaml schema.
>
> This should be dropped or reverted.
>
> > Suggested-by: Uwe Kleine-König <ukleinek@kernel.org>
> > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
> > ---
> >
> > This is a missing patch to cleanup the required pwm-cells attribute twice[1].
> > Thanks to Uwe for the heads up.
> > [1]:https://lore.kernel.org/linux-pwm/cover.1714450308.git.zhoubinbin@loongson.cn/
> >
> > Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml b/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml
> > index a3e52b22dd18..4c8ce7a26d13 100644
> > --- a/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml
> > +++ b/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml
> > @@ -16,7 +16,6 @@ select:
> > const: renesas,tpu
> > required:
> > - compatible
> > - - '#pwm-cells'
>
> This line is not requiring #pwm-cells, but rather only applying the
> schema when #pwm-cells is present. It is needed because there's also
> renesas,tpu in bindings/timer/renesas,tpu.yaml. Without this,
> linux-next now has these warnings:
>
> [...]
Huh, indeed. I only grepped and didn't notice the context of the line. I
dropped the patch.
Sorry and thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2024-05-09 17:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 6:54 [PATCH] dt-bindings: pwm: renesas,tpu: Do not require pwm-cells twice Binbin Zhou
2024-05-07 14:00 ` Uwe Kleine-König
2024-05-09 13:46 ` Rob Herring
2024-05-09 17:29 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dthqwkvdy7qkkwr6bvvi3mwutuaggnj3xripwa2jvqv4lni5bd@3zlnzotkmmfx \
--to=u.kleine-koenig@pengutronix.de \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-pwm@vger.kernel.org \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=robh+dt@kernel.org \
--cc=ukleinek@kernel.org \
--cc=zhoubb.aaron@gmail.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).