From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
Banajit Goswami <bgoswami@quicinc.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: <linux-arm-msm@vger.kernel.org>, <alsa-devel@alsa-project.org>,
<linux-sound@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <quic_rohkumar@quicinc.com>,
<quic_pkumpatl@quicinc.com>
Subject: Re: [PATCH v3 2/7] ASoC: codecs: wcd937x: add wcd937x codec driver
Date: Tue, 7 May 2024 17:10:10 +0530 [thread overview]
Message-ID: <ed691f73-d56e-a653-d4bf-229a3ec561f1@quicinc.com> (raw)
In-Reply-To: <59f78ca7-ea09-41d7-9e6e-b0ce1af484e4@linux.intel.com>
On 4/25/2024 7:13 PM, Pierre-Louis Bossart wrote:
>
>> +struct wcd937x_priv {
>> + struct sdw_slave *tx_sdw_dev;
>> + struct sdw_slave *rx_sdw_dev;
>
> Does this mean that the codec has 2 SoundWire interfaces?
Yes, Similar to WCD938x
(https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/sound/soc/codecs/wcd938x.c?h=next-20240507),
it has two soundwire interfaces.
All read/write operations associated with WCD937x goes over tx_sdw.
rx_sdw_dev is unused in this driver. I will remove it.
>
> If yes, aren't there merits in splitting the implementation in two
> separate drivers, one for each interface and probing on the relevant partID?
>
> This is how the RT713 was handled. The mic function was exposed as the
> RT1713.
>
> By representing the device as a single entity, things could be fun
> because the two interfaces are really independent. things like clock
> stop are handled at the interface level.
>
> The code in this driver is difficult to review, for example in the probe
> you wait for the TX part to complete the enumeration/initialization, but
> there's nothing mentioned or stated on the RX part, and there's really
> nothing related to the detection of this device. I don't actually see a
> sdw_driver at all, it's a platform driver.
>
wcd937x waits for TX part to complete as it is needed for register
read/write operations.
Please refer patch 3/7 for slave driver.
> Would you mind adding a paragraph on how the SoundWire interfaces are
> handled and how the SoundWire bus is involved if there's no sdw_driver?
>
> Thanks!
Sure, will add details in the commit message.
Soundwire master driver is already upstreamed and is available at
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/soundwire/qcom.c?h=next-20240507
Thanks & Regards,
Rafi.
next prev parent reply other threads:[~2024-05-07 11:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 9:18 [PATCH v3 0/7] ASoC: codecs: wcd937x: add wcd937x audio codec support Mohammad Rafi Shaik
2024-04-25 9:18 ` [PATCH v3 1/7] ASoC: dt-bindings: document wcd937x Audio Codec Mohammad Rafi Shaik
2024-04-25 10:38 ` Rob Herring
2024-04-25 11:01 ` Krzysztof Kozlowski
2024-04-25 11:47 ` Mohammad Rafi Shaik
2024-04-25 11:53 ` Krzysztof Kozlowski
2024-04-25 9:18 ` [PATCH v3 2/7] ASoC: codecs: wcd937x: add wcd937x codec driver Mohammad Rafi Shaik
2024-04-25 13:43 ` Pierre-Louis Bossart
2024-05-07 11:40 ` Mohammad Rafi Shaik [this message]
2024-04-25 9:18 ` [PATCH v3 3/7] ASoC: codecs: wcd937x-sdw: add SoundWire driver Mohammad Rafi Shaik
2024-04-25 9:18 ` [PATCH v3 4/7] ASoC: codecs: wcd937x: add basic controls Mohammad Rafi Shaik
2024-04-25 9:18 ` [PATCH v3 5/7] ASoC: codecs: wcd937x: add playback dapm widgets Mohammad Rafi Shaik
2024-04-25 9:18 ` [PATCH v3 6/7] ASoC: codecs: wcd937x: add capture " Mohammad Rafi Shaik
2024-04-25 9:18 ` [PATCH v3 7/7] ASoC: codecs: wcd937x: add audio routing and Kconfig Mohammad Rafi Shaik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed691f73-d56e-a653-d4bf-229a3ec561f1@quicinc.com \
--to=quic_mohs@quicinc.com \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=quic_pkumpatl@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).