From: Quentin Schulz <quentin.schulz@cherry.de>
To: Heiko Stuebner <heiko@sntech.de>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org
Cc: andy.yan@rock-chips.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Heiko Stuebner <heiko.stuebner@cherry.de>
Subject: Re: [PATCH] dt-bindings: soc: rockchip: add rk3588 mipi dcphy syscon
Date: Tue, 7 May 2024 18:48:46 +0200 [thread overview]
Message-ID: <f44c76ac-3dc1-45d6-b435-e5b77b708d6e@cherry.de> (raw)
In-Reply-To: <20240506124632.3621378-1-heiko@sntech.de>
Hi Heiko,
On 5/6/24 2:46 PM, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@cherry.de>
>
> RK3588 CSI and DSI support requires the GRF for DC-PHY.
>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>
> ---
> Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> index 0b87c266760c6..0131c62893450 100644
> --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> @@ -22,6 +22,7 @@ properties:
> - rockchip,rk3568-usb2phy-grf
> - rockchip,rk3588-bigcore0-grf
> - rockchip,rk3588-bigcore1-grf
> + - rockchip,rk3588-dcphy-grf
There are two. While the TRM states:
"""
There are two MIPICDPHY_GRF modules in RK3588.They have different base
address.
"""
(ignore the typo :) )
it states the same for the bigcore grf but we have two bindings for them
in there... So not sure what to go for here? Similarly, pipe-grf has
three instances but we define only one binding...
So who knows :)
That being said,
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Thanks!
Quentin
prev parent reply other threads:[~2024-05-07 16:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 12:46 [PATCH] dt-bindings: soc: rockchip: add rk3588 mipi dcphy syscon Heiko Stuebner
2024-05-07 15:08 ` Conor Dooley
2024-05-07 16:48 ` Quentin Schulz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f44c76ac-3dc1-45d6-b435-e5b77b708d6e@cherry.de \
--to=quentin.schulz@cherry.de \
--cc=andy.yan@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko.stuebner@cherry.de \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).