* [PATCH v4 1/2] dt-bindings: display: bridge: ldb: Implement simple Freescale i.MX8MP LDB bridge
@ 2022-04-26 19:36 Marek Vasut
2022-05-02 14:46 ` Robert Foss
2022-05-03 0:31 ` Rob Herring
0 siblings, 2 replies; 8+ messages in thread
From: Marek Vasut @ 2022-04-26 19:36 UTC (permalink / raw
To: dri-devel
Cc: robert.foss, Marek Vasut, Sam Ravnborg, Laurent Pinchart,
Lucas Stach, Maxime Ripard, Peng Fan, Rob Herring, Robby Cai,
Thomas Zimmermann, devicetree
The i.MX8MP contains two syscon registers which are responsible
for configuring the on-SoC DPI-to-LVDS serializer. Add DT binding
which represents this serializer as a bridge.
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Maxime Ripard <maxime@cerno.tech>
Cc: Peng Fan <peng.fan@nxp.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Robby Cai <robby.cai@nxp.com>
Cc: Robert Foss <robert.foss@linaro.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: devicetree@vger.kernel.org
To: dri-devel@lists.freedesktop.org
---
V2: - Consistently use fsl,imx8mp-ldb as compatible
- Drop items: from compatible:
- Replace minItems with maxItems in clocks:
- Drop quotes from clock-names const: ldb
- Rename syscon to fsl,syscon
- Use generic name of ldb-lvds in example
V3: - Add AB from Sam
- Consistently use MX8MP
V4: - Rename to fsl-ldb all over the place
- Put the LDB node under media block controller in the example
---
.../bindings/display/bridge/fsl,ldb.yaml | 92 +++++++++++++++++++
1 file changed, 92 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
new file mode 100644
index 000000000000..77f174eee424
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
@@ -0,0 +1,92 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/bridge/fsl,ldb.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Freescale i.MX8MP DPI to LVDS bridge chip
+
+maintainers:
+ - Marek Vasut <marex@denx.de>
+
+description: |
+ The i.MX8MP mediamix contains two registers which are responsible
+ for configuring the on-SoC DPI-to-LVDS serializer. This describes
+ those registers as bridge within the DT.
+
+properties:
+ compatible:
+ const: fsl,imx8mp-ldb
+
+ clocks:
+ maxItems: 1
+
+ clock-names:
+ const: ldb
+
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+
+ properties:
+ port@0:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: Video port for DPI input.
+
+ port@1:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: Video port for LVDS Channel-A output (panel or bridge).
+
+ port@2:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: Video port for LVDS Channel-B output (panel or bridge).
+
+ required:
+ - port@0
+ - port@1
+
+required:
+ - compatible
+ - clocks
+ - ports
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/imx8mp-clock.h>
+
+ blk-ctrl {
+ bridge {
+ compatible = "fsl,imx8mp-ldb";
+ clocks = <&clk IMX8MP_CLK_MEDIA_LDB>;
+ clock-names = "ldb";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ ldb_from_lcdif2: endpoint {
+ remote-endpoint = <&lcdif2_to_ldb>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ ldb_lvds_ch0: endpoint {
+ remote-endpoint = <&ldb_to_lvdsx4panel>;
+ };
+ };
+
+ port@2 {
+ reg = <2>;
+
+ ldb_lvds_ch1: endpoint {
+ };
+ };
+ };
+ };
+ };
--
2.35.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: display: bridge: ldb: Implement simple Freescale i.MX8MP LDB bridge
2022-04-26 19:36 [PATCH v4 1/2] dt-bindings: display: bridge: ldb: Implement simple Freescale i.MX8MP LDB bridge Marek Vasut
@ 2022-05-02 14:46 ` Robert Foss
2022-05-02 17:09 ` Marek Vasut
2022-05-03 0:31 ` Rob Herring
1 sibling, 1 reply; 8+ messages in thread
From: Robert Foss @ 2022-05-02 14:46 UTC (permalink / raw
To: Marek Vasut
Cc: dri-devel, Sam Ravnborg, Laurent Pinchart, Lucas Stach,
Maxime Ripard, Peng Fan, Rob Herring, Robby Cai,
Thomas Zimmermann, devicetree
On Tue, 26 Apr 2022 at 21:37, Marek Vasut <marex@denx.de> wrote:
>
> The i.MX8MP contains two syscon registers which are responsible
> for configuring the on-SoC DPI-to-LVDS serializer. Add DT binding
> which represents this serializer as a bridge.
>
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Maxime Ripard <maxime@cerno.tech>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Robby Cai <robby.cai@nxp.com>
> Cc: Robert Foss <robert.foss@linaro.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: devicetree@vger.kernel.org
> To: dri-devel@lists.freedesktop.org
> ---
> V2: - Consistently use fsl,imx8mp-ldb as compatible
> - Drop items: from compatible:
> - Replace minItems with maxItems in clocks:
> - Drop quotes from clock-names const: ldb
> - Rename syscon to fsl,syscon
> - Use generic name of ldb-lvds in example
> V3: - Add AB from Sam
> - Consistently use MX8MP
> V4: - Rename to fsl-ldb all over the place
> - Put the LDB node under media block controller in the example
> ---
> .../bindings/display/bridge/fsl,ldb.yaml | 92 +++++++++++++++++++
> 1 file changed, 92 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
> new file mode 100644
> index 000000000000..77f174eee424
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
> @@ -0,0 +1,92 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/bridge/fsl,ldb.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale i.MX8MP DPI to LVDS bridge chip
> +
> +maintainers:
> + - Marek Vasut <marex@denx.de>
> +
> +description: |
> + The i.MX8MP mediamix contains two registers which are responsible
> + for configuring the on-SoC DPI-to-LVDS serializer. This describes
> + those registers as bridge within the DT.
> +
> +properties:
> + compatible:
> + const: fsl,imx8mp-ldb
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + const: ldb
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + properties:
> + port@0:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: Video port for DPI input.
> +
> + port@1:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: Video port for LVDS Channel-A output (panel or bridge).
> +
> + port@2:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: Video port for LVDS Channel-B output (panel or bridge).
> +
> + required:
> + - port@0
> + - port@1
> +
> +required:
> + - compatible
> + - clocks
> + - ports
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/imx8mp-clock.h>
> +
> + blk-ctrl {
> + bridge {
> + compatible = "fsl,imx8mp-ldb";
> + clocks = <&clk IMX8MP_CLK_MEDIA_LDB>;
> + clock-names = "ldb";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> +
> + ldb_from_lcdif2: endpoint {
> + remote-endpoint = <&lcdif2_to_ldb>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> +
> + ldb_lvds_ch0: endpoint {
> + remote-endpoint = <&ldb_to_lvdsx4panel>;
> + };
> + };
> +
> + port@2 {
> + reg = <2>;
> +
> + ldb_lvds_ch1: endpoint {
> + };
> + };
> + };
> + };
> + };
> --
Applied series to drm-misc-next.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: display: bridge: ldb: Implement simple Freescale i.MX8MP LDB bridge
2022-05-02 14:46 ` Robert Foss
@ 2022-05-02 17:09 ` Marek Vasut
0 siblings, 0 replies; 8+ messages in thread
From: Marek Vasut @ 2022-05-02 17:09 UTC (permalink / raw
To: Robert Foss
Cc: dri-devel, Sam Ravnborg, Laurent Pinchart, Lucas Stach,
Maxime Ripard, Peng Fan, Rob Herring, Robby Cai,
Thomas Zimmermann, devicetree
On 5/2/22 16:46, Robert Foss wrote:
> On Tue, 26 Apr 2022 at 21:37, Marek Vasut <marex@denx.de> wrote:
>>
>> The i.MX8MP contains two syscon registers which are responsible
>> for configuring the on-SoC DPI-to-LVDS serializer. Add DT binding
>> which represents this serializer as a bridge.
>>
>> Acked-by: Sam Ravnborg <sam@ravnborg.org>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> Cc: Lucas Stach <l.stach@pengutronix.de>
>> Cc: Maxime Ripard <maxime@cerno.tech>
>> Cc: Peng Fan <peng.fan@nxp.com>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: Robby Cai <robby.cai@nxp.com>
>> Cc: Robert Foss <robert.foss@linaro.org>
>> Cc: Sam Ravnborg <sam@ravnborg.org>
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: devicetree@vger.kernel.org
>> To: dri-devel@lists.freedesktop.org
>> ---
>> V2: - Consistently use fsl,imx8mp-ldb as compatible
>> - Drop items: from compatible:
>> - Replace minItems with maxItems in clocks:
>> - Drop quotes from clock-names const: ldb
>> - Rename syscon to fsl,syscon
>> - Use generic name of ldb-lvds in example
>> V3: - Add AB from Sam
>> - Consistently use MX8MP
>> V4: - Rename to fsl-ldb all over the place
>> - Put the LDB node under media block controller in the example
>> ---
>> .../bindings/display/bridge/fsl,ldb.yaml | 92 +++++++++++++++++++
>> 1 file changed, 92 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
>> new file mode 100644
>> index 000000000000..77f174eee424
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
>> @@ -0,0 +1,92 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/bridge/fsl,ldb.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Freescale i.MX8MP DPI to LVDS bridge chip
>> +
>> +maintainers:
>> + - Marek Vasut <marex@denx.de>
>> +
>> +description: |
>> + The i.MX8MP mediamix contains two registers which are responsible
>> + for configuring the on-SoC DPI-to-LVDS serializer. This describes
>> + those registers as bridge within the DT.
>> +
>> +properties:
>> + compatible:
>> + const: fsl,imx8mp-ldb
>> +
>> + clocks:
>> + maxItems: 1
>> +
>> + clock-names:
>> + const: ldb
>> +
>> + ports:
>> + $ref: /schemas/graph.yaml#/properties/ports
>> +
>> + properties:
>> + port@0:
>> + $ref: /schemas/graph.yaml#/properties/port
>> + description: Video port for DPI input.
>> +
>> + port@1:
>> + $ref: /schemas/graph.yaml#/properties/port
>> + description: Video port for LVDS Channel-A output (panel or bridge).
>> +
>> + port@2:
>> + $ref: /schemas/graph.yaml#/properties/port
>> + description: Video port for LVDS Channel-B output (panel or bridge).
>> +
>> + required:
>> + - port@0
>> + - port@1
>> +
>> +required:
>> + - compatible
>> + - clocks
>> + - ports
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/clock/imx8mp-clock.h>
>> +
>> + blk-ctrl {
>> + bridge {
>> + compatible = "fsl,imx8mp-ldb";
>> + clocks = <&clk IMX8MP_CLK_MEDIA_LDB>;
>> + clock-names = "ldb";
>> +
>> + ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + port@0 {
>> + reg = <0>;
>> +
>> + ldb_from_lcdif2: endpoint {
>> + remote-endpoint = <&lcdif2_to_ldb>;
>> + };
>> + };
>> +
>> + port@1 {
>> + reg = <1>;
>> +
>> + ldb_lvds_ch0: endpoint {
>> + remote-endpoint = <&ldb_to_lvdsx4panel>;
>> + };
>> + };
>> +
>> + port@2 {
>> + reg = <2>;
>> +
>> + ldb_lvds_ch1: endpoint {
>> + };
>> + };
>> + };
>> + };
>> + };
>> --
>
> Applied series to drm-misc-next.
You probably wanted an AB/RB from Lucas on this, maybe a fixup patch
will be needed.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: display: bridge: ldb: Implement simple Freescale i.MX8MP LDB bridge
2022-04-26 19:36 [PATCH v4 1/2] dt-bindings: display: bridge: ldb: Implement simple Freescale i.MX8MP LDB bridge Marek Vasut
2022-05-02 14:46 ` Robert Foss
@ 2022-05-03 0:31 ` Rob Herring
2022-05-03 12:03 ` Robert Foss
2022-05-04 1:30 ` Marek Vasut
1 sibling, 2 replies; 8+ messages in thread
From: Rob Herring @ 2022-05-03 0:31 UTC (permalink / raw
To: Marek Vasut
Cc: dri-devel, robert.foss, Sam Ravnborg, Laurent Pinchart,
Lucas Stach, Maxime Ripard, Peng Fan, Robby Cai,
Thomas Zimmermann, devicetree
On Tue, Apr 26, 2022 at 09:36:44PM +0200, Marek Vasut wrote:
> The i.MX8MP contains two syscon registers which are responsible
> for configuring the on-SoC DPI-to-LVDS serializer. Add DT binding
> which represents this serializer as a bridge.
>
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Maxime Ripard <maxime@cerno.tech>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Robby Cai <robby.cai@nxp.com>
> Cc: Robert Foss <robert.foss@linaro.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: devicetree@vger.kernel.org
> To: dri-devel@lists.freedesktop.org
> ---
> V2: - Consistently use fsl,imx8mp-ldb as compatible
> - Drop items: from compatible:
> - Replace minItems with maxItems in clocks:
> - Drop quotes from clock-names const: ldb
> - Rename syscon to fsl,syscon
> - Use generic name of ldb-lvds in example
> V3: - Add AB from Sam
> - Consistently use MX8MP
> V4: - Rename to fsl-ldb all over the place
> - Put the LDB node under media block controller in the example
> ---
> .../bindings/display/bridge/fsl,ldb.yaml | 92 +++++++++++++++++++
> 1 file changed, 92 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
A little quick on the applying...
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
> new file mode 100644
> index 000000000000..77f174eee424
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
> @@ -0,0 +1,92 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/bridge/fsl,ldb.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale i.MX8MP DPI to LVDS bridge chip
> +
> +maintainers:
> + - Marek Vasut <marex@denx.de>
> +
> +description: |
> + The i.MX8MP mediamix contains two registers which are responsible
> + for configuring the on-SoC DPI-to-LVDS serializer. This describes
> + those registers as bridge within the DT.
This is a subblock of the mediamix? Please add 'reg' for the 2 registers
even if you use a regmap.
I didn't find a binding for mediamix. You really need the containing
block binding before a child node.
Rob
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: display: bridge: ldb: Implement simple Freescale i.MX8MP LDB bridge
2022-05-03 0:31 ` Rob Herring
@ 2022-05-03 12:03 ` Robert Foss
2022-05-03 13:46 ` Marek Vasut
2022-05-04 1:30 ` Marek Vasut
1 sibling, 1 reply; 8+ messages in thread
From: Robert Foss @ 2022-05-03 12:03 UTC (permalink / raw
To: Rob Herring
Cc: Marek Vasut, dri-devel, Sam Ravnborg, Laurent Pinchart,
Lucas Stach, Maxime Ripard, Peng Fan, Robby Cai,
Thomas Zimmermann, devicetree
On Tue, 3 May 2022 at 02:31, Rob Herring <robh@kernel.org> wrote:
>
> On Tue, Apr 26, 2022 at 09:36:44PM +0200, Marek Vasut wrote:
> > The i.MX8MP contains two syscon registers which are responsible
> > for configuring the on-SoC DPI-to-LVDS serializer. Add DT binding
> > which represents this serializer as a bridge.
> >
> > Acked-by: Sam Ravnborg <sam@ravnborg.org>
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Cc: Lucas Stach <l.stach@pengutronix.de>
> > Cc: Maxime Ripard <maxime@cerno.tech>
> > Cc: Peng Fan <peng.fan@nxp.com>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: Robby Cai <robby.cai@nxp.com>
> > Cc: Robert Foss <robert.foss@linaro.org>
> > Cc: Sam Ravnborg <sam@ravnborg.org>
> > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> > Cc: devicetree@vger.kernel.org
> > To: dri-devel@lists.freedesktop.org
> > ---
> > V2: - Consistently use fsl,imx8mp-ldb as compatible
> > - Drop items: from compatible:
> > - Replace minItems with maxItems in clocks:
> > - Drop quotes from clock-names const: ldb
> > - Rename syscon to fsl,syscon
> > - Use generic name of ldb-lvds in example
> > V3: - Add AB from Sam
> > - Consistently use MX8MP
> > V4: - Rename to fsl-ldb all over the place
> > - Put the LDB node under media block controller in the example
> > ---
> > .../bindings/display/bridge/fsl,ldb.yaml | 92 +++++++++++++++++++
> > 1 file changed, 92 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
>
> A little quick on the applying...
Darnit, you're right.
Marek: Can you supply a new patch with all of the relevant changes?
>
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
> > new file mode 100644
> > index 000000000000..77f174eee424
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
> > @@ -0,0 +1,92 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/bridge/fsl,ldb.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Freescale i.MX8MP DPI to LVDS bridge chip
> > +
> > +maintainers:
> > + - Marek Vasut <marex@denx.de>
> > +
> > +description: |
> > + The i.MX8MP mediamix contains two registers which are responsible
> > + for configuring the on-SoC DPI-to-LVDS serializer. This describes
> > + those registers as bridge within the DT.
>
> This is a subblock of the mediamix? Please add 'reg' for the 2 registers
> even if you use a regmap.
>
> I didn't find a binding for mediamix. You really need the containing
> block binding before a child node.
>
> Rob
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: display: bridge: ldb: Implement simple Freescale i.MX8MP LDB bridge
2022-05-03 12:03 ` Robert Foss
@ 2022-05-03 13:46 ` Marek Vasut
0 siblings, 0 replies; 8+ messages in thread
From: Marek Vasut @ 2022-05-03 13:46 UTC (permalink / raw
To: Robert Foss, Rob Herring
Cc: dri-devel, Sam Ravnborg, Laurent Pinchart, Lucas Stach,
Maxime Ripard, Peng Fan, Robby Cai, Thomas Zimmermann, devicetree
On 5/3/22 14:03, Robert Foss wrote:
> On Tue, 3 May 2022 at 02:31, Rob Herring <robh@kernel.org> wrote:
>>
>> On Tue, Apr 26, 2022 at 09:36:44PM +0200, Marek Vasut wrote:
>>> The i.MX8MP contains two syscon registers which are responsible
>>> for configuring the on-SoC DPI-to-LVDS serializer. Add DT binding
>>> which represents this serializer as a bridge.
>>>
>>> Acked-by: Sam Ravnborg <sam@ravnborg.org>
>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>>> Cc: Lucas Stach <l.stach@pengutronix.de>
>>> Cc: Maxime Ripard <maxime@cerno.tech>
>>> Cc: Peng Fan <peng.fan@nxp.com>
>>> Cc: Rob Herring <robh+dt@kernel.org>
>>> Cc: Robby Cai <robby.cai@nxp.com>
>>> Cc: Robert Foss <robert.foss@linaro.org>
>>> Cc: Sam Ravnborg <sam@ravnborg.org>
>>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>>> Cc: devicetree@vger.kernel.org
>>> To: dri-devel@lists.freedesktop.org
>>> ---
>>> V2: - Consistently use fsl,imx8mp-ldb as compatible
>>> - Drop items: from compatible:
>>> - Replace minItems with maxItems in clocks:
>>> - Drop quotes from clock-names const: ldb
>>> - Rename syscon to fsl,syscon
>>> - Use generic name of ldb-lvds in example
>>> V3: - Add AB from Sam
>>> - Consistently use MX8MP
>>> V4: - Rename to fsl-ldb all over the place
>>> - Put the LDB node under media block controller in the example
>>> ---
>>> .../bindings/display/bridge/fsl,ldb.yaml | 92 +++++++++++++++++++
>>> 1 file changed, 92 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
>>
>> A little quick on the applying...
>
> Darnit, you're right.
>
> Marek: Can you supply a new patch with all of the relevant changes?
Sure, it's coming today-ish or so.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: display: bridge: ldb: Implement simple Freescale i.MX8MP LDB bridge
2022-05-03 0:31 ` Rob Herring
2022-05-03 12:03 ` Robert Foss
@ 2022-05-04 1:30 ` Marek Vasut
2022-05-06 11:21 ` Robert Foss
1 sibling, 1 reply; 8+ messages in thread
From: Marek Vasut @ 2022-05-04 1:30 UTC (permalink / raw
To: Rob Herring
Cc: dri-devel, robert.foss, Sam Ravnborg, Laurent Pinchart,
Lucas Stach, Maxime Ripard, Peng Fan, Robby Cai,
Thomas Zimmermann, devicetree
On 5/3/22 02:31, Rob Herring wrote:
Hi,
[...]
>> .../bindings/display/bridge/fsl,ldb.yaml | 92 +++++++++++++++++++
>> 1 file changed, 92 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
>
> A little quick on the applying...
Right
>> diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
>> new file mode 100644
>> index 000000000000..77f174eee424
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
>> @@ -0,0 +1,92 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/bridge/fsl,ldb.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Freescale i.MX8MP DPI to LVDS bridge chip
>> +
>> +maintainers:
>> + - Marek Vasut <marex@denx.de>
>> +
>> +description: |
>> + The i.MX8MP mediamix contains two registers which are responsible
>> + for configuring the on-SoC DPI-to-LVDS serializer. This describes
>> + those registers as bridge within the DT.
>
> This is a subblock of the mediamix? Please add 'reg' for the 2 registers
> even if you use a regmap.
I submitted a patch:
[PATCH] dt-bindings: display: bridge: ldb: Fill in reg property
> I didn't find a binding for mediamix. You really need the containing
> block binding before a child node.
Right, I'm tempted to send a revert outright and wait for the mediamix
bindings to hit upstream.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: display: bridge: ldb: Implement simple Freescale i.MX8MP LDB bridge
2022-05-04 1:30 ` Marek Vasut
@ 2022-05-06 11:21 ` Robert Foss
0 siblings, 0 replies; 8+ messages in thread
From: Robert Foss @ 2022-05-06 11:21 UTC (permalink / raw
To: Marek Vasut
Cc: Rob Herring, dri-devel, Sam Ravnborg, Laurent Pinchart,
Lucas Stach, Maxime Ripard, Peng Fan, Robby Cai,
Thomas Zimmermann, devicetree
> >> +description: |
> >> + The i.MX8MP mediamix contains two registers which are responsible
> >> + for configuring the on-SoC DPI-to-LVDS serializer. This describes
> >> + those registers as bridge within the DT.
> >
> > This is a subblock of the mediamix? Please add 'reg' for the 2 registers
> > even if you use a regmap.
>
> I submitted a patch:
> [PATCH] dt-bindings: display: bridge: ldb: Fill in reg property
Would you like me to apply this, or do you want to revert all of the above?
>
> > I didn't find a binding for mediamix. You really need the containing
> > block binding before a child node.
>
> Right, I'm tempted to send a revert outright and wait for the mediamix
> bindings to hit upstream.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-05-06 11:22 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-26 19:36 [PATCH v4 1/2] dt-bindings: display: bridge: ldb: Implement simple Freescale i.MX8MP LDB bridge Marek Vasut
2022-05-02 14:46 ` Robert Foss
2022-05-02 17:09 ` Marek Vasut
2022-05-03 0:31 ` Rob Herring
2022-05-03 12:03 ` Robert Foss
2022-05-03 13:46 ` Marek Vasut
2022-05-04 1:30 ` Marek Vasut
2022-05-06 11:21 ` Robert Foss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).