From: Nathan Chancellor <nathan@kernel.org>
To: Pratham Patel <prathampatel@thefossguy.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Nicolas Schier <nicolas@fjasle.eu>,
Jonathan Corbet <corbet@lwn.net>,
linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, thefirst1322@gmail.com
Subject: Re: [PATCH 0/2] Enable building of the devel RPM package from Kbuild
Date: Wed, 17 Apr 2024 08:47:50 -0700 [thread overview]
Message-ID: <20240417154750.GB1517581@dev-arch.thelio-3990X> (raw)
In-Reply-To: <D0MHQUIYGONC.3LTT2WN2885D7@thefossguy.com>
On Wed, Apr 17, 2024 at 03:08:57PM +0000, Pratham Patel wrote:
> On Wed Apr 17, 2024 at 8:18 PM IST, Nathan Chancellor wrote:
> > On Wed, Apr 17, 2024 at 04:37:32AM +0000, Pratham Patel wrote:
> > > This addresses a minor nit where I want a `-devel` RPM package to be
> > > built when I build a binary RPM package with either `binrpm-pkg`
> > > or `rpm-pkg` target(s).
> > >
> > > Pratham Patel (2):
> > > kbuild: allow toggling the `with_devel` RPM macro
> > > docs: kbuild: document KBUILD_RPM_WITH_DEVEL
> > >
> > > Documentation/kbuild/kbuild.rst | 6 ++++++
> > > scripts/Makefile.package | 5 ++++-
> > > 2 files changed, 10 insertions(+), 1 deletion(-)
> > >
> > > --
> > > 2.42.0
> > >
> >
> > Hmmm, when I execute
> >
> > $ make -skj"$(nproc)" ARCH=x86_64 O=build mrproper defconfig binrpm-pkg
> >
> > I end up with
> >
> > $ ls -1 build/rpmbuild/RPMS/x86_64
> > kernel-6.9.0_rc4_00031_g96fca68c4fbf-1.x86_64.rpm
> > kernel-devel-6.9.0_rc4_00031_g96fca68c4fbf-1.x86_64.rpm
> > kernel-headers-6.9.0_rc4_00031_g96fca68c4fbf-1.x86_64.rpm
> >
> > so it seems like this is already happening?
> >
> > Cheers,
> > Nathan
>
> Ah sorry, that was a typo. I meant to say the following:
> "This addresses a minor nit where I **don't** want a `-devel` RPM
> package to be built when I build a binary RPM package with either
> `binrpm-pkg` or `rpm-pkg` target(s)."
>
> That is because on ARM systems where I just need to quickly test the
> upstream defconfig, I don't really need the `-devel` package.
>
> Also, I see that in a hurry, I did the opposite of what I wanted in the
> patches. This went unnoticed since I had KBUILD_RPM_WITH_DEVEL=0 for me
> during testing. Sorry about that!
>
> I'll send a v2 fixing this stupid mistake.
Ah, understood! I am not sure you actually need a v2 though because I
think you can already accomplish what you are looking for by adding
RPMOPTS='--without devel'
to your make command, at least that works for me. Commit 2a291fc315b6
("kbuild: rpm-pkg: introduce %{with_devel} switch to select devel
package") introduced this.
Cheers,
Nathan
next prev parent reply other threads:[~2024-04-17 15:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 4:37 [PATCH 0/2] Enable building of the devel RPM package from Kbuild Pratham Patel
2024-04-17 4:37 ` [PATCH 1/2] kbuild: allow toggling the `with_devel` RPM macro Pratham Patel
2024-04-17 4:37 ` [PATCH 2/2] docs: kbuild: document KBUILD_RPM_WITH_DEVEL Pratham Patel
2024-04-17 14:48 ` [PATCH 0/2] Enable building of the devel RPM package from Kbuild Nathan Chancellor
2024-04-17 15:08 ` Pratham Patel
2024-04-17 15:47 ` Nathan Chancellor [this message]
2024-04-17 15:50 ` Pratham Patel
2024-04-20 7:29 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240417154750.GB1517581@dev-arch.thelio-3990X \
--to=nathan@kernel.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=prathampatel@thefossguy.com \
--cc=thefirst1322@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).