From: Greg KH <gregkh@linuxfoundation.org>
To: qiurui <happyqiuqiu9604@gmail.com>
Cc: corbet@lwn.net, linux-usb@vger.kernel.org,
linux-doc@vger.kernel.org, qiurui@kylinos.cn
Subject: Re: [PATCH] docs: usb:gadget:hid: fix hid_gadget_test code in documentation of hid section
Date: Fri, 10 May 2024 10:32:57 +0100 [thread overview]
Message-ID: <2024051011-nearby-mowing-e53a@gregkh> (raw)
In-Reply-To: <20240506024408.19344-1-qiurui@kylinos.cn>
On Mon, May 06, 2024 at 10:44:08AM +0800, qiurui wrote:
> Fix bzero buffer before read()
>
> Signed-off-by: qiurui <qiurui@kylinos.cn>
> ---
> Documentation/usb/gadget_hid.rst | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/usb/gadget_hid.rst b/Documentation/usb/gadget_hid.rst
> index e623416de4f1..c4ee81a6b48e 100644
> --- a/Documentation/usb/gadget_hid.rst
> +++ b/Documentation/usb/gadget_hid.rst
> @@ -410,6 +410,7 @@ Sample code::
> }
>
> if (FD_ISSET(fd, &rfds)) {
> + bzero(buf, SIZE);
> cmd_len = read(fd, buf, BUF_LEN - 1);
> printf("recv report:");
> for (i = 0; i < cmd_len; i++)
> @@ -419,6 +420,7 @@ Sample code::
>
> if (FD_ISSET(STDIN_FILENO, &rfds)) {
> memset(report, 0x0, sizeof(report));
> + bzero(buf, SIZE);
> cmd_len = read(STDIN_FILENO, buf, BUF_LEN - 1);
>
> if (cmd_len == 0)
> --
> 2.34.1
>
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- You did not specify a description of why the patch is needed, or
possibly, any description at all, in the email body. Please read the
section entitled "The canonical patch format" in the kernel file,
Documentation/process/submitting-patches.rst for what is needed in
order to properly describe the change.
- You did not write a descriptive Subject: for the patch, allowing Greg,
and everyone else, to know what this patch is all about. Please read
the section entitled "The canonical patch format" in the kernel file,
Documentation/process/submitting-patches.rst for what a proper
Subject: line should look like.
- It looks like you did not use your "real" name for the patch on either
the Signed-off-by: line, or the From: line (both of which have to
match). Please read the kernel file,
Documentation/process/submitting-patches.rst for how to do this
correctly.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
prev parent reply other threads:[~2024-05-10 9:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 2:44 [PATCH] docs: usb:gadget:hid: fix hid_gadget_test code in documentation of hid section qiurui
2024-05-06 5:34 ` Matthew Wilcox
2024-05-10 9:32 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024051011-nearby-mowing-e53a@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=corbet@lwn.net \
--cc=happyqiuqiu9604@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=qiurui@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).