From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Alper Nebi Yasak" <alpernebiyasak@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Banajit Goswami" <bgoswami@quicinc.com>,
"Bard Liao" <yung-chuan.liao@linux.intel.com>,
"Brent Lu" <brent.lu@intel.com>,
"Cezary Rojewski" <cezary.rojewski@intel.com>,
"Charles Keepax" <ckeepax@opensource.cirrus.com>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Cristian Ciocaltea" <cristian.ciocaltea@collabora.com>,
"Daniel Baluta" <daniel.baluta@nxp.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Jaroslav Kysela" <perex@perex.cz>, "Jiawei Wang" <me@jwang.link>,
"Jonathan Corbet" <corbet@lwn.net>,
"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
"Kevin Hilman" <khilman@baylibre.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Maso Huang" <maso.huang@mediatek.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Peter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
"Ranjani Sridharan" <ranjani.sridharan@linux.intel.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Shawn Guo" <shawnguo@kernel.org>,
"Shengjiu Wang" <shengjiu.wang@gmail.com>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
"Takashi Iwai" <tiwai@suse.com>, "Vinod Koul" <vkoul@kernel.org>,
"Xiubo Li" <Xiubo.Lee@gmail.com>,
alsa-devel@alsa-project.org, imx@lists.linux.dev,
linux-doc@vger.kernel.org, linux-sound@vger.kernel.org
Subject: Re: [PATCH 0/3] ASoC: grace time for DPCM cleanup
Date: Thu, 9 May 2024 23:42:32 +0000 [thread overview]
Message-ID: <878r0ir1qw.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <1j1q6b1gxs.fsf@starbuckisacylon.baylibre.com>
Hi Jerome
Thank you for your reply
> >> If so, did you get below warning too ?
> >> "both playback/capture are available, but not using playback_only flag (%s)\n",
> >>
>
> I've checked. No such trace, no.
OK, thanks
> >> Card
> >> dpcm_playback = (0 or 1)
> >> dpcm_capture = (0 or 1)
> >> playback_only = (0 or 1)
> >> capture_only = (0 or 1)
> >> BE.CPU
> >> playback = (available, not available)
> >> capture = (available, not available)
> >> BE.Codec
> >> playback = (available, not available)
> >> capture = (available, not available)
> >> Expect
> >> playback = (available, not available)
> >> capture = (available, not available)
>
> I'm not too sure I undestand this. I'll try to illustrate the case
> raising the warning as precisely as possible bellow
Thanks
Because you got was
(A) axg-sound-card sound: CPU capture is available but Codec capture is
not (be.dai-link-6) Please update Codec driver
It is for BE. And validation check is for each rtd only, this means it checks
BE only, relationship with other rtd is not related here.
> --------
> |CPU BE| This is the TDM interface. Capable of both Playback and
> -------- Capture. Through routing it can be connected to Playback
> ^ and/or Capture FE CPUs.
> |
> V
> -------------
> |BE Codec(s)| Possibly N codecs, supporting both direction, or a
> ------------- Single one, or one direction each. In this particular case
> | it is Playback only C2C.
So, I think the warning happen here.
The validation check is checking this BE only.
As I mentioned above, you use this BE through playback only FE and/or C2C,
but that relationship is not related to here.
According to above explanation, this BE itself is available for both
playback and capture. And you didn't get below warning, I guess this BE
has both dpcm_playback/capture flag, and no xxx_only flag.
"both playback/capture are available, but not using playback_only
flag (%s)\n",
Before my patch, the validation check is checks CPU-BE only, but it also
checks BE-Codec after my patch, and you got the warning (A).
So, I guess your BE-Codec simply missing capture channels_min settings.
Please double check it, or please tell me which codec driver this BE is
using.
static struct snd_soc_dai_driver xxx_dai = {
...
.playback = {
...
.channels_min = x,
...
},
.capture = {
...
=> .channels_min = x,
...
},
},
> But I noticed that we want to update below. I'm happy if it can solve your
> issue.
>
> - if (has_playback && !has_playback_both)
> + if (has_playback && !has_playback_both && !dai_link->capture_only)
> dev_warn(rtd->card->dev, ...)
>
> - if (has_capture && !has_capture_both)
> + if (has_capture && !has_capture_both && !dai_link->playback_only)
> dev_warn(rtd->card->dev, ...)
>
> Honestly I'm a bit lost in all these flag :/
Thanks, no problem, me too :9
Unfortunately and confusingly, there are many combination exist around here.
But because of your feedback, I noticed one missing pattern. Thanks
Thank you for your help !!
Best regards
---
Renesas Electronics
Ph.D. Kuninori Morimoto
next prev parent reply other threads:[~2024-05-09 23:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 4:32 [PATCH 0/3] ASoC: grace time for DPCM cleanup Kuninori Morimoto
2024-05-07 8:47 ` Jerome Brunet
2024-05-08 0:06 ` Kuninori Morimoto
2024-05-09 5:50 ` Kuninori Morimoto
2024-05-09 8:51 ` Jerome Brunet
2024-05-09 23:42 ` Kuninori Morimoto [this message]
2024-05-12 9:33 ` Jerome Brunet
2024-05-13 0:11 ` Kuninori Morimoto
2024-05-13 7:36 ` Jerome Brunet
2024-05-13 23:42 ` Kuninori Morimoto
2024-05-14 9:04 ` Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r0ir1qw.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alpernebiyasak@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bgoswami@quicinc.com \
--cc=brent.lu@intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=corbet@lwn.net \
--cc=cristian.ciocaltea@collabora.com \
--cc=daniel.baluta@nxp.com \
--cc=hdegoede@redhat.com \
--cc=imx@lists.linux.dev \
--cc=jbrunet@baylibre.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=khilman@baylibre.com \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=maso.huang@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=me@jwang.link \
--cc=neil.armstrong@linaro.org \
--cc=nicolas.ferre@microchip.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=s.hauer@pengutronix.de \
--cc=s.nawrocki@samsung.com \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).