From: Alan Stern <stern@rowland.harvard.edu>
To: Michael Grzeschik <mgr@pengutronix.de>
Cc: Eric Van Hensbergen <ericvh@kernel.org>,
Latchesar Ionkov <lucho@ionkov.net>,
Dominique Martinet <asmadeus@codewreck.org>,
Christian Schoenebeck <linux_oss@crudebyte.com>,
Jonathan Corbet <corbet@lwn.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
v9fs@lists.linux.dev, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH v4 1/3] usb: gadget: function: move u_f.h to include/linux/usb/
Date: Wed, 1 May 2024 10:19:18 -0400 [thread overview]
Message-ID: <96fe85f7-eaf1-4231-985b-14514cf53f3d@rowland.harvard.edu> (raw)
In-Reply-To: <ZjH_cx_0uBLc6M6L@pengutronix.de>
On Wed, May 01, 2024 at 10:38:11AM +0200, Michael Grzeschik wrote:
> On Mon, Apr 29, 2024 at 09:51:20PM -0400, Alan Stern wrote:
> > On Tue, Apr 30, 2024 at 01:33:26AM +0200, Michael Grzeschik wrote:
> > > We move the u_f.h header to include/linux/usb to be
> > > able to compile function drivers outside of the
> > > drivers/usb/gadget/function directory.
> > >
> > > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> >
> > Given that you're moving a private header file to a public location,
> > don't you think it should now have a name that's more meaningful to
> > general kernel developers than "u_f.h"?
>
> Fair point.
>
> How about func_utils.h instead?
Yes, that would be a lot better. Especially if you put it in
include/linux/usb/gadget rather than include/linux/usb.
Thanks.
Alan Stern
next prev parent reply other threads:[~2024-05-01 14:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 23:33 [PATCH v4 0/3] usb: gadget: 9pfs transport Michael Grzeschik
2024-04-29 23:33 ` [PATCH v4 1/3] usb: gadget: function: move u_f.h to include/linux/usb/ Michael Grzeschik
2024-04-30 1:51 ` Alan Stern
2024-05-01 8:38 ` Michael Grzeschik
2024-05-01 14:19 ` Alan Stern [this message]
2024-04-29 23:33 ` [PATCH v4 2/3] net/9p/usbg: Add new usb gadget function transport Michael Grzeschik
2024-05-10 9:25 ` Andrzej Pietrasiewicz
2024-05-10 10:11 ` Michael Grzeschik
2024-05-10 14:11 ` Andrzej Pietrasiewicz
2024-05-16 18:49 ` Michael Grzeschik
2024-05-16 19:51 ` Michael Grzeschik
2024-05-28 5:21 ` Michael Grzeschik
2024-04-29 23:33 ` [PATCH v4 3/3] tools: usb: p9_fwd: add usb gadget packet forwarder script Michael Grzeschik
2024-05-10 8:29 ` Andrzej Pietrasiewicz
2024-05-10 8:32 ` Andrzej Pietrasiewicz
2024-05-28 5:19 ` Michael Grzeschik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96fe85f7-eaf1-4231-985b-14514cf53f3d@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=asmadeus@codewreck.org \
--cc=corbet@lwn.net \
--cc=ericvh@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=mgr@pengutronix.de \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).