From: "SanBuenaventura, Jose" <Jose.SanBuenaventura@analog.com>
To: Guenter Roeck <linux@roeck-us.net>,
Krzysztof Kozlowski <krzk@kernel.org>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Cc: Jean Delvare <jdelvare@suse.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
Subject: RE: [PATCH v2 0/2] Add adm1281 support
Date: Mon, 22 Apr 2024 04:09:51 +0000 [thread overview]
Message-ID: <PH0PR03MB6607B80801B186F4E1ADA7F1EC122@PH0PR03MB6607.namprd03.prod.outlook.com> (raw)
In-Reply-To: <2292b566-7fde-4834-a9a4-a74b14235541@roeck-us.net>
> -----Original Message-----
> From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck
> Sent: Monday, April 22, 2024 11:45 AM
> To: Krzysztof Kozlowski <krzk@kernel.org>; SanBuenaventura, Jose
> <Jose.SanBuenaventura@analog.com>; linux-hwmon@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> doc@vger.kernel.org; linux-i2c@vger.kernel.org
> Cc: Jean Delvare <jdelvare@suse.com>; Rob Herring <robh@kernel.org>;
> Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley
> <conor+dt@kernel.org>; Jonathan Corbet <corbet@lwn.net>; Delphine CC
> Chiu <Delphine_CC_Chiu@Wiwynn.com>
> Subject: Re: [PATCH v2 0/2] Add adm1281 support
>
> [External]
>
> On 4/21/24 20:28, Krzysztof Kozlowski wrote:
> > On 22/04/2024 04:51, Jose Ramon San Buenaventura wrote:
> >> This patch removes the extra case added in the adm1275_read_byte_data
> >> for STATUS_CML reads. Upon checking, the reads for the STATUS_CML
> >> register is already handled in the pmbus_core.
> >>
> >> It was also clarified and agreed upon that any other actionable steps
> >> involving the STATUS_CML error flags should be added in the
> >> pmbus_core and not on the specific chip driver.
> >>
> >
> > Where is the changelog? It's v2, so what happened here?
> >
>
> Same question.
>
> Guenter
>
Hello,
The only change from v1 to v2 is the removal of the additional case
for STATUS_CML in the adm1275_read_byte_data function in the adm1275.c
driver code. No changes were done in the other files, only in the driver code.
I apologize for the confusion.
For clarification, do I need to resend the patches and include a changelog
in the patch that specifies the changes done i.e., v1 -> v2: removed case?
Joram
prev parent reply other threads:[~2024-04-22 4:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 2:51 [PATCH v2 0/2] Add adm1281 support Jose Ramon San Buenaventura
2024-04-22 2:51 ` [PATCH v2 1/2] dt-bindings: hwmon: adm1275: add adm1281 Jose Ramon San Buenaventura
2024-04-22 2:51 ` [PATCH v2 2/2] hwmon: pmbus: adm1275: add adm1281 support Jose Ramon San Buenaventura
2024-04-22 7:20 ` Nuno Sá
2024-04-22 3:28 ` [PATCH v2 0/2] Add " Krzysztof Kozlowski
2024-04-22 3:45 ` Guenter Roeck
2024-04-22 4:09 ` SanBuenaventura, Jose [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR03MB6607B80801B186F4E1ADA7F1EC122@PH0PR03MB6607.namprd03.prod.outlook.com \
--to=jose.sanbuenaventura@analog.com \
--cc=Delphine_CC_Chiu@Wiwynn.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).