From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: workflows@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH v1 2/2] Documentation: process: Recommend to put Cc: tags after cutter '---' line
Date: Tue, 23 Apr 2024 19:12:55 +0300 [thread overview]
Message-ID: <ZifeB_7DLa10BU__@smile.fi.intel.com> (raw)
In-Reply-To: <2024042317-wolf-condition-dd5f@gregkh>
On Tue, Apr 23, 2024 at 09:07:09AM -0700, Greg KH wrote:
> On Tue, Apr 23, 2024 at 06:28:44PM +0300, Andy Shevchenko wrote:
> > On Tue, Apr 23, 2024 at 08:13:37AM -0700, Greg KH wrote:
> > > On Tue, Apr 23, 2024 at 04:19:38PM +0300, Andy Shevchenko wrote:
> > > > The recommendation is based on the following rationale:
> > > >
> > > > - it makes the commit messages much cleaner and easy to read, especially
> > > > on the screens of the mobile devices;
> > >
> > > Reading commits on a mobile device is not what kernel development is
> > > optimized for, sorry.
> >
> > The commit messages not always for the kernel development, some people may read
> > them in order to understand code better or many other reasons. I.o.w. it's not
> > the point.
> >
> > > > - it reduces resources (memory, time, energy) to retrieve all these
> > > > headers, which are barely needed by a mere user, as for automation
> > > > they will be still available via mail archives, such as
> > > > https://lore.kernel.org, assuming the Link: or Message-ID tag is
> > > > provided.
> > > >
> > > > Let's be environment friendly and save the planet!
> > > >
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > > ---
> > > > Documentation/process/5.Posting.rst | 4 ++++
> > > > Documentation/process/submitting-patches.rst | 5 +++++
> > > > 2 files changed, 9 insertions(+)
> > >
> > > This breaks my existing workflow, sorry. I can't track cc: below the
> > > --- line because obviously, git cuts that off. So I put them above
> > > where git send-email can see them,
> >
> > git send-email _sees_ them very well there.
>
> Sorry, yes, but git itself can't track them in the commit when I
> rebase/squash/redo/etc. That's the point I was trying to make before my
> coffee kicked in...
It can in your _local_ repo if you have it as
Signed-off-by:
---
Cc:
Cc:
in the commit message. It won't go to the final commit message if you sending
it out and apply via `git am`, or reapply with the latter locally instead of
cherry-picking.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-04-23 16:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 13:19 [PATCH v1 0/2] Documentation: process: Clarify use of Cc: Andy Shevchenko
2024-04-23 13:19 ` [PATCH v1 1/2] Documentation: process: Avoid unneeded Cc: tags Andy Shevchenko
2024-04-23 17:13 ` Dan Williams
2024-04-29 7:37 ` Krzysztof Kozlowski
2024-04-23 13:19 ` [PATCH v1 2/2] Documentation: process: Recommend to put Cc: tags after cutter '---' line Andy Shevchenko
2024-04-23 14:30 ` Jani Nikula
2024-04-23 14:37 ` Andy Shevchenko
2024-04-23 14:44 ` Jonathan Corbet
2024-04-23 16:46 ` Andy Shevchenko
2024-04-23 16:37 ` Jani Nikula
2024-04-23 16:45 ` Andy Shevchenko
2024-04-23 17:00 ` Jani Nikula
2024-04-23 17:04 ` Konstantin Ryabitsev
2024-04-23 15:26 ` Geert Uytterhoeven
2024-04-24 1:10 ` Mark Brown
2024-04-23 15:13 ` Greg KH
2024-04-23 15:28 ` Andy Shevchenko
2024-04-23 16:07 ` Greg KH
2024-04-23 16:12 ` Andy Shevchenko [this message]
2024-04-29 7:35 ` Krzysztof Kozlowski
2024-04-29 8:44 ` Andy Shevchenko
2024-04-23 13:59 ` [PATCH v1 0/2] Documentation: process: Clarify use of Cc: Geert Uytterhoeven
2024-04-24 14:53 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZifeB_7DLa10BU__@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).