From: Arnaldo Carvalho de Melo <acme-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Jan Engelhardt <jengelh-nopoi9nDyk+ELgA04lAiVw@public.gmane.org>
Cc: dwarves-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: pahole displays type incorrectly
Date: Sat, 12 Sep 2009 19:47:31 -0300 [thread overview]
Message-ID: <20090912224731.GD3545@ghostprotocols.net> (raw)
In-Reply-To: <20090912144939.GA14242-f8uhVLnGfZaxAyOMLChx1axOck334EZe@public.gmane.org>
Em Sat, Sep 12, 2009 at 11:49:39AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Sat, Sep 12, 2009 at 10:24:05AM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Sat, Sep 12, 2009 at 03:41:56AM +0200, Jan Engelhardt escreveu:
> > >
> > > On Thursday 2009-09-10 22:35, Arnaldo Carvalho de Melo wrote:
> > > >
> > > >Sorry for the delay, should be fixed by the latest commit, please give
> > > >it a try!
> > > >
> > > >http://git.kernel.org/?p=linux/kernel/git/acme/pahole.git;a=commitdiff;h=846927a3f87f730e0ae201b5f0b3b46212a7bb8e
> > >
> > > Yes it does work. The testcase seems to be reducable to just the
> > > struct without a function, but still with a non-static definition
> > > (instance) of the struct. I.e. on the file level:
> > >
> > > struct foo {
> > > const char *const z;
> > > };
> > > struct foo x;
> >
> > Thanks for testing! I'll update the test case to reduce it.
>
> While running regtest I noticed it is still buggy :-\ It works when you
> have a "const char *const x" case, but reverses both "const char *x"
> and "char *const x", but now parents are visiting, time to go AFK :-)
>
> If anybody feels like looking at the latest commits to see how it
> should't be done and comes with a patch, I'd appreciate 8-)
Should be ok now. See lest cset, with test cases for:
const char *x;
char *const x;
const char *const x;
- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe dwarves" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-09-12 22:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LSU.2.00.0908171610490.31821@fbirervta.pbzchgretzou.qr>
[not found] ` <20090817154228.GI12303@ghostprotocols.net>
[not found] ` <20090817154228.GI12303-f8uhVLnGfZaxAyOMLChx1axOck334EZe@public.gmane.org>
2009-09-10 20:35 ` pahole displays type incorrectly Arnaldo Carvalho de Melo
[not found] ` <20090910222256.GB2289@ghostprotocols.net>
[not found] ` <20090910222256.GB2289-f8uhVLnGfZaxAyOMLChx1axOck334EZe@public.gmane.org>
2009-09-11 4:54 ` Arnaldo Carvalho de Melo
[not found] ` <20090910203517.GA2289-f8uhVLnGfZaxAyOMLChx1axOck334EZe@public.gmane.org>
2009-09-12 1:41 ` Jan Engelhardt
[not found] ` <alpine.LSU.2.00.0909120340020.444-SHaQjdQMGhDmsUXKMKRlFA@public.gmane.org>
2009-09-12 13:24 ` Arnaldo Carvalho de Melo
[not found] ` <20090912132405.GB3545-f8uhVLnGfZaxAyOMLChx1axOck334EZe@public.gmane.org>
2009-09-12 14:49 ` Arnaldo Carvalho de Melo
[not found] ` <20090912144939.GA14242-f8uhVLnGfZaxAyOMLChx1axOck334EZe@public.gmane.org>
2009-09-12 22:47 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090912224731.GD3545@ghostprotocols.net \
--to=acme-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=dwarves-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jengelh-nopoi9nDyk+ELgA04lAiVw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).