From: Borislav Petkov <bp@alien8.de>
To: Tony Luck <tony.luck@intel.com>
Cc: "Naik, Avadhut" <avadnaik@amd.com>,
"Mehta, Sohil" <sohil.mehta@intel.com>,
Yazen Ghannam <yazen.ghannam@amd.com>,
x86@kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] x86/mce: Dynamically size space for machine check records
Date: Tue, 26 Mar 2024 12:49:45 +0100 [thread overview]
Message-ID: <20240326114945.GEZgK2WUJRKexfQomR@fat_crate.local> (raw)
In-Reply-To: <20240307192704.37213-1-tony.luck@intel.com>
On Thu, Mar 07, 2024 at 11:27:04AM -0800, Tony Luck wrote:
> - ret = gen_pool_add(tmpp, (unsigned long)gen_pool_buf, MCE_POOLSZ, -1);
> + mce_numrecords = max(MCE_MIN_ENTRIES, num_possible_cpus() * MCE_PER_CPU);
> + mce_poolsz = mce_numrecords * (1 << order);
So, on a big fat machine with 8K CPUs that's, what
8192 * 2 * (1 << 8) = ~4M
buffer?
Well, if you have a fat machine, you get fat buffers too.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2024-03-26 11:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 19:27 [PATCH v3] x86/mce: Dynamically size space for machine check records Tony Luck
2024-03-11 5:38 ` Naik, Avadhut
2024-03-26 11:49 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240326114945.GEZgK2WUJRKexfQomR@fat_crate.local \
--to=bp@alien8.de \
--cc=avadnaik@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sohil.mehta@intel.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).