From: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
To: Borislav Petkov <bp@alien8.de>, Tony Luck <tony.luck@intel.com>,
James Morse <james.morse@arm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Robert Richter <rric@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: dan.carpenter@linaro.org, kernel-janitors@vger.kernel.org,
error27@gmail.com
Subject: Re: [PATCH] EDAC/sysfs: Fix calling kobj_put() with ->state_initialized unset
Date: Wed, 29 Nov 2023 00:03:40 +0530 [thread overview]
Message-ID: <4b715de8-f815-4768-a817-f558ae375955@oracle.com> (raw)
In-Reply-To: <20231127072558.2999920-1-harshit.m.mogalapalli@oracle.com>
Hi,
On 27/11/23 12:55 pm, Harshit Mogalapalli wrote:
> In edac_device_register_sysfs_main_kobj(), when dev_root is NULL,
> kobject_init_and_add() is not called.
>
> if (err) { // err = -ENODEV
> edac_dbg(1, "Failed to register '.../edac/%s'\n",
> edac_dev->name);
> goto err_kobj_reg; // This calls kobj_put()
> }
>
> This will cause a runtime warning in kobject_put() if the above happens.
> Warning:
> "kobject: '%s' (%p): is not initialized, yet kobject_put() is being called."
>
> Fix the error handling to avoid the above possible situation.
>
> Fixes: cb4a0bec0bb9 ("EDAC/sysfs: move to use bus_get_dev_root()")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
> ---
I have sent a v2 as a patch series fixing two very similar bugs:
https://lore.kernel.org/all/20231128183037.3395755-1-harshit.m.mogalapalli@oracle.com/
> This is only compile tested and based on static analysis with Smatch.
> ---
> drivers/edac/edac_device_sysfs.c | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/edac/edac_device_sysfs.c b/drivers/edac/edac_device_sysfs.c
> index 010c26be5846..4cac14cbdb60 100644
> --- a/drivers/edac/edac_device_sysfs.c
> +++ b/drivers/edac/edac_device_sysfs.c
> @@ -253,11 +253,13 @@ int edac_device_register_sysfs_main_kobj(struct edac_device_ctl_info *edac_dev)
>
> /* register */
> dev_root = bus_get_dev_root(edac_subsys);
> - if (dev_root) {
> - err = kobject_init_and_add(&edac_dev->kobj, &ktype_device_ctrl,
> - &dev_root->kobj, "%s", edac_dev->name);
> - put_device(dev_root);
> - }
> + if (!dev_root)
> + goto module_put;
> +
> + err = kobject_init_and_add(&edac_dev->kobj, &ktype_device_ctrl,
> + &dev_root->kobj, "%s", edac_dev->name);
> + put_device(dev_root);
> +
> if (err) {
> edac_dbg(1, "Failed to register '.../edac/%s'\n",
> edac_dev->name);
> @@ -276,8 +278,8 @@ int edac_device_register_sysfs_main_kobj(struct edac_device_ctl_info *edac_dev)
> /* Error exit stack */
> err_kobj_reg:
> kobject_put(&edac_dev->kobj);
> +module_put:
> module_put(edac_dev->owner);
> -
> err_out:
> return err;
> }
prev parent reply other threads:[~2023-11-28 18:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 7:25 [PATCH] EDAC/sysfs: Fix calling kobj_put() with ->state_initialized unset Harshit Mogalapalli
2023-11-28 18:33 ` Harshit Mogalapalli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b715de8-f815-4768-a817-f558ae375955@oracle.com \
--to=harshit.m.mogalapalli@oracle.com \
--cc=bp@alien8.de \
--cc=dan.carpenter@linaro.org \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=james.morse@arm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).