From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: yazen.ghannam@amd.com, Guenter Roeck <linux@roeck-us.net>,
x86@kernel.org, Mario Limonciello <mario.limonciello@amd.com>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v3 3/8] hwmon: (k10temp) Check return value of amd_smn_read()
Date: Wed, 5 Jun 2024 12:30:35 -0400 [thread overview]
Message-ID: <e17b38fe-97cb-4559-be97-36af0ab14789@amd.com> (raw)
In-Reply-To: <20240605161236.GIZmCOdP-CRPJ8-3sY@fat_crate.local>
On 6/5/24 12:12 PM, Borislav Petkov wrote:
> On Wed, Jun 05, 2024 at 09:41:51AM -0400, Yazen Ghannam wrote:
>> I agree that patches 1-3 are not stable-worthy on their own. But I think
>> patch 4 is, and it requires 1-3 to avoid build errors.
>
> Which of the rules in the first section of
> Documentation/process/stable-kernel-rules.rst apply for patch 4?
>
> Because I don't see it.
>
"It fixes a problem like ... a hardware quirk ..."
This is described in patch 4:
---
Most systems will return 0 for SMN addresses that are not accessible.
This is in line with AMD convention that unavailable registers are
Read-as-Zero/Writes-Ignored.
However, some systems will return a "PCI Error Response" instead. This
value, along with an error code of 0 from the PCI config access, will
confuse callers of the amd_smn_read() function.
---
But I think it's fine to drop the stable tag after reading through the
rules again. I'll do option 2 or 3 if there's interest for specific
branches. And the cherry-pick thing should be easy to do if all the
prerequisites are already upstream.
Thanks,
Yazen
next prev parent reply other threads:[~2024-06-05 16:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 18:26 [PATCH v3 0/8] Enhance AMD SMN Error Checking Yazen Ghannam
2024-05-23 18:26 ` [PATCH v3 1/8] EDAC/amd64: Remove unused register accesses Yazen Ghannam
2024-06-05 8:51 ` Borislav Petkov
2024-05-23 18:26 ` [PATCH v3 2/8] EDAC/amd64: Check return value of amd_smn_read() Yazen Ghannam
2024-05-25 13:22 ` Markus Elfring
2024-06-05 9:47 ` Borislav Petkov
2024-05-23 18:26 ` [PATCH v3 3/8] hwmon: (k10temp) " Yazen Ghannam
2024-05-25 13:32 ` Markus Elfring
2024-06-05 12:20 ` Borislav Petkov
2024-06-05 13:41 ` Yazen Ghannam
2024-06-05 16:12 ` Borislav Petkov
2024-06-05 16:30 ` Yazen Ghannam [this message]
2024-06-05 16:45 ` Borislav Petkov
2024-06-05 17:41 ` Yazen Ghannam
2024-05-23 18:26 ` [PATCH v3 4/8] x86/amd_nb: Enhance SMN access error checking Yazen Ghannam
2024-05-25 13:55 ` Markus Elfring
2024-05-23 18:26 ` [PATCH v3 5/8] hwmon: (k10temp) Define helper function to read CCD temp Yazen Ghannam
2024-05-23 18:26 ` [PATCH v3 6/8] hwmon: (k10temp) Reduce k10temp_get_ccd_support() parameters Yazen Ghannam
2024-05-25 14:43 ` Markus Elfring
2024-05-23 18:26 ` [PATCH v3 7/8] hwmon: (k10temp) Remove unused HAVE_TDIE() macro Yazen Ghannam
2024-05-23 19:31 ` Guenter Roeck
2024-05-25 15:00 ` Markus Elfring
2024-05-23 18:26 ` [PATCH v3 8/8] hwmon: (k10temp) Rename _data variable Yazen Ghannam
2024-05-23 19:32 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e17b38fe-97cb-4559-be97-36af0ab14789@amd.com \
--to=yazen.ghannam@amd.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mario.limonciello@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).