From: Rob Herring <robh@kernel.org>
To: Saravana Kannan <saravanak@google.com>
Cc: linux-efi@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Daniel Scally <djrscally@gmail.com>,
Frank Rowand <frowand.list@gmail.com>,
linux-kernel@vger.kernel.org, kernel-team@android.com,
devicetree@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH v2 3/4] dt-bindings: Add post-init-supplier property
Date: Mon, 12 Feb 2024 16:17:16 -0600 [thread overview]
Message-ID: <170777623558.2654155.17686339859837179281.robh@kernel.org> (raw)
In-Reply-To: <20240212213147.489377-4-saravanak@google.com>
On Mon, 12 Feb 2024 13:31:44 -0800, Saravana Kannan wrote:
> The post-init-supplier property can be used to break a dependency cycle by
> marking some supplier(s) as a post device initialization supplier(s). This
> allows an OS to do a better job at ordering initialization and
> suspend/resume of the devices in a dependency cycle.
>
> Signed-off-by: Saravana Kannan <saravanak@google.com>
> ---
> .../bindings/post-init-supplier.yaml | 101 ++++++++++++++++++
> MAINTAINERS | 13 +--
> 2 files changed, 108 insertions(+), 6 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/post-init-supplier.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/post-init-supplier.yaml:84:12: [error] syntax error: mapping values are not allowed here (syntax)
dtschema/dtc warnings/errors:
make[2]: *** Deleting file 'Documentation/devicetree/bindings/post-init-supplier.example.dts'
Documentation/devicetree/bindings/post-init-supplier.yaml:84:12: mapping values are not allowed in this context
make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/post-init-supplier.example.dts] Error 1
make[2]: *** Waiting for unfinished jobs....
./Documentation/devicetree/bindings/post-init-supplier.yaml:84:12: mapping values are not allowed in this context
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/post-init-supplier.yaml: ignoring, error parsing file
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1428: dt_binding_check] Error 2
make: *** [Makefile:240: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240212213147.489377-4-saravanak@google.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-02-12 22:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 21:31 [PATCH v2 0/4] Add post-init-supplier binding to improve suspend/resume stability Saravana Kannan
2024-02-12 21:31 ` [PATCH v2 1/4] driver core: Adds flags param to fwnode_link_add() Saravana Kannan
2024-02-12 21:31 ` [PATCH v2 2/4] driver core: Add FWLINK_FLAG_IGNORE to completely ignore a fwnode link Saravana Kannan
2024-02-12 21:31 ` [PATCH v2 3/4] dt-bindings: Add post-init-supplier property Saravana Kannan
2024-02-12 22:17 ` Rob Herring [this message]
2024-02-14 18:48 ` Conor Dooley
2024-02-14 19:13 ` Conor Dooley
2024-02-14 23:32 ` Saravana Kannan
2024-02-15 12:14 ` Conor Dooley
2024-02-21 4:13 ` Saravana Kannan
2024-02-21 19:34 ` Conor Dooley
2024-02-21 22:47 ` Saravana Kannan
2024-02-17 10:27 ` Krzysztof Kozlowski
2024-02-21 4:07 ` Saravana Kannan
2024-02-21 7:21 ` Krzysztof Kozlowski
2024-02-21 14:32 ` Rob Herring
2024-02-12 21:31 ` [PATCH v2 4/4] of: property: fw_devlink: Add support for "post-init-supplier" property Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170777623558.2654155.17686339859837179281.robh@kernel.org \
--to=robh@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ardb@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djrscally@gmail.com \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kernel-team@android.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).