From: Greg KH <gregkh@linuxfoundation.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Ted Brandston <tbrandston@google.com>,
linux-efi@vger.kernel.org, stable@vger.kernel.org,
Jiao Zhou <jiaozhou@google.com>,
Nicholas Bishop <nicholasbishop@google.com>
Subject: Re: efivarfs fixes without the commit being fixed in 6.1 and 6.6 (resending without html)
Date: Thu, 21 Mar 2024 16:34:08 +0100 [thread overview]
Message-ID: <2024032151-tweet-attractor-3b6f@gregkh> (raw)
In-Reply-To: <CAMj1kXEKfAKJM0o-X5vY9cMpkurvpZ418GpyS5fWqiZO-0H9wg@mail.gmail.com>
On Thu, Mar 21, 2024 at 04:28:56PM +0100, Ard Biesheuvel wrote:
> On Thu, 21 Mar 2024 at 15:59, Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Thu, Mar 21, 2024 at 10:43:05AM -0400, Ted Brandston wrote:
> > > Hi, this is my first time posting to a kernel list (third try, finally
> > > figured out the html-free -- sorry for the noise).
> > >
> > > I noticed that in the 6.6 kernel there's a fix commit from Ard [1] but
> > > not the commit it's fixing ("efivarfs: Add uid/gid mount options").
> > > Same thing in 6.1 [2]. The commit being fixed doesn't appear until 6.7
> > > [3].
> > >
> > > I'm not familiar with this code so it's unclear to me if this might
> > > cause problems, but I figured I should point it out.
> > >
> > > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/fs/efivarfs/super.c?h=linux-6.6.y&id=48be1364dd387e375e1274b76af986cb8747be2c
> > > [2]: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/log/fs/efivarfs/super.c?h=linux-6.1.y
> > > [3]: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/log/fs/efivarfs/super.c?h=linux-6.7.y
> >
> > Good catch.
>
> Indeed. Thanks for reporting this.
>
> > Ard, should this be reverted?
> >
>
> With this fix applied, we'll end up kfree()'ing a pointer that is
> guaranteed to be NULL, on a code path that typically executes once per
> boot, if at all.
>
> So in practical terms, there is really no difference, and this is the
> only thing I personally care about.
>
> So I wouldn't mind if we just left them, unless there are other
> concerns wrt to maintenance, tidiness etc.
>
Ok, let's leave it, as long as there's no bad side affects.
greg k-h
prev parent reply other threads:[~2024-03-21 15:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA+eDQTFQ45nWGmctp-CkK=xXXQQHc_DTkM1iN4m-0o5fCjt8VA@mail.gmail.com>
2024-03-21 14:43 ` efivarfs fixes without the commit being fixed in 6.1 and 6.6 (resending without html) Ted Brandston
2024-03-21 14:58 ` Greg KH
2024-03-21 15:28 ` Ard Biesheuvel
2024-03-21 15:34 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024032151-tweet-attractor-3b6f@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=ardb@kernel.org \
--cc=jiaozhou@google.com \
--cc=linux-efi@vger.kernel.org \
--cc=nicholasbishop@google.com \
--cc=stable@vger.kernel.org \
--cc=tbrandston@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).