From: Ira Weiny <ira.weiny@intel.com>
To: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
Ira Weiny <ira.weiny@intel.com>, <linux-efi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>
Cc: Ard Biesheuvel <ardb@kernel.org>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
"Dan Williams" <dan.j.williams@intel.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Yazen Ghannam <yazen.ghannam@amd.com>
Subject: Re: [PATCH 3/4] acpi/ghes, efi/cper: Recognize and process CXL Protocol Errors.
Date: Wed, 3 Jan 2024 14:32:22 -0800 [thread overview]
Message-ID: <6595e076cac24_3ec8294fb@iweiny-mobl.notmuch> (raw)
In-Reply-To: <66b7feb6-b151-ad97-0ee4-3fd7da7137eb@amd.com>
Smita Koralahalli wrote:
> On 1/2/2024 9:58 AM, Ira Weiny wrote:
> > Smita Koralahalli wrote:
[snip]
> >> +
> >> + return 0;
> >> +}
> >> diff --git a/include/linux/cxl-event.h b/include/linux/cxl-event.h
> >> index 90d8390a73cb..7ba2dfd6619e 100644
> >> --- a/include/linux/cxl-event.h
> >> +++ b/include/linux/cxl-event.h
> >> @@ -154,11 +154,17 @@ struct cxl_ras_capability_regs {
> >>
> >> struct cxl_cper_rec_data {
> >> struct cxl_cper_event_rec rec;
> >> + struct cxl_ras_capability_regs *cxl_ras;
> >> + int severity;
> >
> > NIT: When I saw this without any addition to event type I wondered if the
> > series would bisect. I see it does because the record is not sent until
> > the next patch. But I wonder if the 2 patches would be best reversed.
>
> You mean to say patch 4 to be 3 and 3 to be 4?
>
> And since I haven't used severity yet, fix it by declaring severity to
> where it is used..
Yes. What you have is not technically wrong but it threw me in review.
>
> >
> > Also, should cxl_ras + severity be put in a protocol error sub-struct?
> > Does severity ever apply to event records?
>
> No, not in any of the component event records. Only place is in "Event
> Record Flags" in Common Event Record Format (Table 8-42).
>
> Addressed in patch 1 to make a sub-struct.
Thanks!
Ira
next prev parent reply other threads:[~2024-01-03 22:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-02 15:09 [PATCH 0/4] acpi/ghes, cper, cxl: Trace FW-First CXL Protocol Errors Smita Koralahalli
2024-01-02 15:09 ` [PATCH 1/4] acpi/ghes, cxl: Create a common CXL struct to handle different CXL CPER records Smita Koralahalli
2024-01-02 16:23 ` Ira Weiny
2024-01-03 20:04 ` Smita Koralahalli
2024-01-03 20:35 ` Ira Weiny
2024-01-02 15:09 ` [PATCH 2/4] efi/cper, cxl: Make definitions and structures global Smita Koralahalli
2024-01-02 16:30 ` Ira Weiny
2024-01-03 20:16 ` Smita Koralahalli
2024-01-03 22:30 ` Ira Weiny
2024-01-02 15:09 ` [PATCH 3/4] acpi/ghes, efi/cper: Recognize and process CXL Protocol Errors Smita Koralahalli
2024-01-02 17:58 ` Ira Weiny
2024-01-03 21:12 ` Smita Koralahalli
2024-01-03 22:32 ` Ira Weiny [this message]
2024-01-02 15:09 ` [PATCH 4/4] acpi/ghes, cxl/pci: Trace FW-First " Smita Koralahalli
2024-01-02 20:27 ` Ira Weiny
2024-01-03 21:13 ` Smita Koralahalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6595e076cac24_3ec8294fb@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=alison.schofield@intel.com \
--cc=ardb@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).