From: Ard Biesheuvel <ardb@kernel.org>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] efi/libstub: Add one kernel-doc comment
Date: Fri, 19 Jan 2024 12:42:25 +0100 [thread overview]
Message-ID: <CAMj1kXEZ3M-RM7i=KkMp8YnDYmamdpZr+MjdHnR2HuNXUYC4KQ@mail.gmail.com> (raw)
In-Reply-To: <20240119100635.12333-1-yang.lee@linux.alibaba.com>
On Fri, 19 Jan 2024 at 11:06, Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> Add the description of @memory_type to silence the warning:
> drivers/firmware/efi/libstub/alignedmem.c:27: warning: Function parameter or struct member 'memory_type' not described in 'efi_allocate_pages_aligned'
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/firmware/efi/libstub/alignedmem.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/firmware/efi/libstub/alignedmem.c b/drivers/firmware/efi/libstub/alignedmem.c
> index 6b83c492c3b8..8ff51c6a2aa1 100644
> --- a/drivers/firmware/efi/libstub/alignedmem.c
> +++ b/drivers/firmware/efi/libstub/alignedmem.c
> @@ -14,6 +14,7 @@
> * @max: the address that the last allocated memory page shall not
> * exceed
> * @align: minimum alignment of the base of the allocation
> + * @memory_type: the type of memory to allocate, as defined by efi_memory_type
What is 'efi_memory_type'?
> *
> * Allocate pages as EFI_LOADER_DATA. The allocated pages are aligned according
> * to @align, which should be >= EFI_ALLOC_ALIGN. The last allocated page will
> --
> 2.20.1.7.g153144c
>
prev parent reply other threads:[~2024-01-19 11:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 10:06 [PATCH -next] efi/libstub: Add one kernel-doc comment Yang Li
2024-01-19 11:42 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXEZ3M-RM7i=KkMp8YnDYmamdpZr+MjdHnR2HuNXUYC4KQ@mail.gmail.com' \
--to=ardb@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).