From: Tony Ibbs <tibs@tonyibbs.co.uk>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Linux-embedded <linux-embedded@vger.kernel.org>,
Tibs at Kynesim <tibs@kynesim.co.uk>,
Richard Watts <rrw@kynesim.co.uk>,
Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCH 5/5] KBUS source file
Date: Mon, 28 Feb 2011 22:25:41 +0000 [thread overview]
Message-ID: <1425A0A7-D946-48BF-9CE0-C54D2FBF8C49@tonyibbs.co.uk> (raw)
In-Reply-To: <20110228192312.GA1832@merkur.ravnborg.org>
On 28 Feb 2011, at 19:23, Sam Ravnborg wrote:
> You are using /proc/* to something that is not process related.
> At lkml you will be requested to use something else.
OK. That's mainly through ignorance of what I *should* be using
instead (and perhaps poor reading of Linux Device Drivers). Do you
have an opinion on where such information should be going?
> You can conisder splitting this up in another file so you
> in the Makefile can use it conditionally.
That makes sense.
>> If there is a better way for me to submit this, please let me know.
>
> One way you would not like....
> Let the first patches introduce core-functionality and add features
> in later patches - touching the same file many times.
Hmm. That's very sensible. Assuming I can figure out a sensible way
to do it (which I assume is what you expected me to object).
It would certainly be interesting to do (sort of reverse archaeology),
but would take a while, and it would, of course, also mean rewriting
all of my tests to only test whatever is still there (I'm assuming a
source file is only interesting if it actually *works*).
It would, of course, also have the advantage of presenting the
"simplest possible" idea of KBUS, followed by "but it appears also to
be necessary to do this" patches. Which is presumably why you suggest
it.
> Also please submit the Makefile/Kconfig stuff in the _last_ mail.
> Otherwise you would ruin bisect because we cannot build kbus until
> you have the last files included.
Ah. Not something I have experience of. I shall make it so.
Thank you,
Tibs
next prev parent reply other threads:[~2011-02-28 22:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-27 18:11 [PATCH 0/5] RFC: KBUS messaging subsystem Tony Ibbs
2011-02-27 18:11 ` [PATCH 1/5] Documentation for KBUS Tony Ibbs
2011-02-27 18:11 ` [PATCH 2/5] External header file " Tony Ibbs
2011-02-27 18:11 ` [PATCH 3/5] Kconfig files and Makefile " Tony Ibbs
2011-02-27 18:11 ` [PATCH 4/5] Internal header file " Tony Ibbs
2011-02-27 18:19 ` [PATCH 3/5] Kconfig files and Makefile " Randy Dunlap
2011-02-27 19:36 ` Tony Ibbs
2011-02-27 19:26 ` [PATCH 5/5] KBUS source file Tony Ibbs
2011-02-27 20:25 ` Randy Dunlap
2011-02-28 19:23 ` Sam Ravnborg
2011-02-28 22:25 ` Tony Ibbs [this message]
2011-03-01 5:42 ` Sam Ravnborg
2011-02-28 7:48 ` [PATCH 0/5] RFC: KBUS messaging subsystem Grant Likely
2011-02-28 7:52 ` Grant Likely
2011-02-28 19:13 ` Tony Ibbs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425A0A7-D946-48BF-9CE0-C54D2FBF8C49@tonyibbs.co.uk \
--to=tibs@tonyibbs.co.uk \
--cc=grant.likely@secretlab.ca \
--cc=linux-embedded@vger.kernel.org \
--cc=rrw@kynesim.co.uk \
--cc=sam@ravnborg.org \
--cc=tibs@kynesim.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).