From: Tony Ibbs <tibs@kynesim.co.uk>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Linux-embedded <linux-embedded@vger.kernel.org>,
Richard Watts <rrw@kynesim.co.uk>,
Tibs at home <tibs@tibsnjoan.co.uk>
Subject: Re: [RFC][PATCH] KBUS messaging subsystem
Date: Thu, 3 Feb 2011 16:59:28 +0000 [thread overview]
Message-ID: <20110203165928.796651d5@spoon> (raw)
In-Reply-To: <20110128191837.GA6781@merkur.ravnborg.org>
On Fri, 28 Jan 2011 20:20:42 +0100
Sam Ravnborg <sam@ravnborg.org> wrote:
> [Edited cc: list as my smtp server refused to send the original reply]
Apologies - I had copied down Grant Likely's email address wrong at ELCE.
> > Should I just submit the patch to this list?
>
> You will get more feedback on lkml...
Indeed. I hoped to start small.
> - use __u32 (and friends) in exported headers - not uint32_t.
OK. I'd missed that. Presumably I should also be using u32 and friends
inside the kernel module itself, instead of uint32_t...
> - do not invent our own logging system. Use one of the standard
> methods.
I vaguely remember having a reason for that. Doubtless it was a bad
one. I shall attend to it.
> If you post for review try to divide it up a little.
> Maybe kbus.c in one patch, Makefile + Kconfig in last patch.
> It is a large file to review already.
That's useful guidance. I shall amend the code as suggested above and
resubmit as smaller, inline patches.
Tibs
next prev parent reply other threads:[~2011-02-03 16:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-28 17:50 [RFC][PATCH] KBUS messaging subsystem Tony Ibbs
2011-01-28 19:20 ` Sam Ravnborg
2011-02-03 16:59 ` Tony Ibbs [this message]
[not found] <20110128180158.6f670a51@spoon>
2011-02-02 3:40 ` Grant Likely
2011-02-03 17:04 ` Tony Ibbs
2011-02-03 17:32 ` Grant Likely
2011-02-06 21:07 ` Tony Ibbs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110203165928.796651d5@spoon \
--to=tibs@kynesim.co.uk \
--cc=linux-embedded@vger.kernel.org \
--cc=rrw@kynesim.co.uk \
--cc=sam@ravnborg.org \
--cc=tibs@tibsnjoan.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).