From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Martin Kelly <martin@martingkelly.com>
Cc: kernel-kbuild@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-embedded@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>,
Matt Mackall <mpm@selenic.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools: fix cross-compile var export
Date: Sun, 7 Jan 2018 14:04:54 -0500 [thread overview]
Message-ID: <20180107190453.GN6273@windriver.com> (raw)
In-Reply-To: <549cf839-9ae7-78ce-58df-3d84fc7b3d05@martingkelly.com>
[Re: [PATCH] tools: fix cross-compile var export] On 07/01/2018 (Sun 10:31) Martin Kelly wrote:
[...]
> With the change, we add do CC = $(CROSS_COMPILE)gcc if and only if CC is not
> already set. I'm happy to add all these details to the commit description.
That is probably a step in the right direction. I contribute to yocto
on a regular basis and hence am sympathetic to these frustrating SDK
type issues. But after a quick scan of this patch it wasn't obvious to
me that existing behaviour was preserved, or that it would be a pain to
separate it into chunks. (key word here being "quick")
So I'd recommend updating the commit log, and adding a Cc: line for the
maintainers of each subsystem below, and then if nobody complains you
might get akpm to pick it up as he does for other patches w/o a clear
maintainer or subsystem.
P.
--
>
> >>
> >> tools/cgroup/Makefile | 1 -
> >> tools/gpio/Makefile | 2 --
> >> tools/hv/Makefile | 1 -
> >> tools/iio/Makefile | 2 --
> >> tools/laptop/freefall/Makefile | 1 -
> >> tools/leds/Makefile | 1 -
> >> tools/perf/Makefile.perf | 6 ------
> >> tools/power/acpi/Makefile.config | 3 ---
> >> tools/scripts/Makefile.include | 18 ++++++++++++++++++
> >> tools/spi/Makefile | 2 --
> >> tools/usb/Makefile | 1 -
> >> tools/vm/Makefile | 1 -
> >> tools/wmi/Makefile | 1 -
> >> 13 files changed, 18 insertions(+), 22 deletions(-)
> >>
next prev parent reply other threads:[~2018-01-07 19:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-06 20:16 [PATCH] tools: fix cross-compile var export Martin Kelly
2018-01-07 16:11 ` Paul Gortmaker
2018-01-07 18:31 ` Martin Kelly
2018-01-07 18:51 ` Martin Kelly
2018-01-08 11:45 ` Dan Carpenter
2018-01-07 19:04 ` Paul Gortmaker [this message]
2018-01-07 21:43 ` Martin Kelly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180107190453.GN6273@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=dwmw2@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel-kbuild@vger.kernel.org \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@martingkelly.com \
--cc=michal.lkml@markovi.net \
--cc=mpm@selenic.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).