From: David Daney <ddaney.cavm@gmail.com>
To: Michal Marek <mmarek@suse.cz>
Cc: David Daney <ddaney.cavm@gmail.com>,
"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
"ralf@linux-mips.org" <ralf@linux-mips.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"linux-embedded@vger.kernel.org" <linux-embedded@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH RFC 3/5] kbuild/extable: Hook up sortextable into the build system.
Date: Tue, 22 Nov 2011 13:38:37 -0800 [thread overview]
Message-ID: <4ECC165D.60300@gmail.com> (raw)
In-Reply-To: <4EC9046C.3050708@suse.cz>
On 11/20/2011 05:45 AM, Michal Marek wrote:
> On 18.11.2011 20:37, David Daney wrote:
>> + $(if $(CONFIG_BUILDTIME_EXTABLE_SORT), \
>> + $(Q)$(if $($(quiet)cmd_sortextable), \
>> + echo ' $($(quiet)cmd_sortextable) vmlinux'&&) \
>> + $(cmd_sortextable) vmlinux)
>
> Why do you opencode $(call cmd,sortextable) here?
>
Mostly just mimicking the other code in the vicinity.
I will try to improve it in the next version of the patch.
Thanks,
David Daney
next prev parent reply other threads:[~2011-11-22 21:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 19:37 [PATCH RFC 0/5] Speed booting by sorting exception tables at build time David Daney
2011-11-18 19:37 ` [PATCH RFC 1/5] scripts: Add sortextable to sort the kernel's exception table David Daney
2011-11-20 23:22 ` Mike Frysinger
2011-11-21 18:25 ` David Daney
2011-11-21 18:50 ` Mike Frysinger
2011-11-21 19:16 ` David Daney
2011-11-21 20:08 ` Mike Frysinger
2011-11-20 23:26 ` H. Peter Anvin
2011-11-20 23:27 ` H. Peter Anvin
2011-11-20 23:28 ` David Woodhouse
2011-11-20 23:30 ` H. Peter Anvin
2011-11-21 18:51 ` David Daney
2011-11-18 19:37 ` [PATCH RFC 2/5] extable: Skip sorting if sorted at build time David Daney
2011-11-18 19:37 ` [PATCH RFC 3/5] kbuild/extable: Hook up sortextable into the build system David Daney
2011-11-20 13:45 ` Michal Marek
2011-11-22 21:38 ` David Daney [this message]
2011-11-18 19:37 ` [PATCH RFC 4/5] MIPS: Select BUILDTIME_EXTABLE_SORT David Daney
2011-11-18 19:37 ` [PATCH RFC 5/5] x86: " David Daney
2011-11-20 23:10 ` [PATCH RFC 0/5] Speed booting by sorting exception tables at build time Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECC165D.60300@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=david.daney@cavium.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mmarek@suse.cz \
--cc=ralf@linux-mips.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).