From: Jiri Kosina <jkosina@suse.cz>
To: Andrew Murray <amurray@mpcdata.com>
Cc: linux-embedded@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Murray <amurray@mpc-data.co.uk>,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH] Bootgraph.pl bug fix
Date: Fri, 10 Jun 2011 15:00:38 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1106101459570.22872@pobox.suse.cz> (raw)
In-Reply-To: <1307655610-28446-1-git-send-email-amurray@mpcdata.com>
On Thu, 9 Jun 2011, Andrew Murray wrote:
> This patch removes the assumption of the bootgraph.pl script that the
> timing information reported by PRINTK_TIME will contain at least one
> entry with a time of less than 100 seconds.
>
> Not all boards correctly reset the system timer and in many cases the
> inital times reported by PRINTK_TIME is high. When this occurs the
> bootchart.pl script fails to give any useful output.
>
> This patch sets the $firsttime variable to the largest value expected
> by PRINTK_TIME
>
> Signed-off-by: Andrew Murray <amurray@mpc-data.co.uk>
> ---
> scripts/bootgraph.pl | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/bootgraph.pl b/scripts/bootgraph.pl
> index 12caa82..b78fca9 100644
> --- a/scripts/bootgraph.pl
> +++ b/scripts/bootgraph.pl
> @@ -44,7 +44,7 @@ my %end;
> my %type;
> my $done = 0;
> my $maxtime = 0;
> -my $firsttime = 100;
> +my $firsttime = 99999;
> my $count = 0;
> my %pids;
> my %pidctr;
Adding Arjan to CC. Arjan, if you are OK with the patch, I can take it
through my tree with your Ack.
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2011-06-10 13:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 21:40 [PATCH] Bootgraph.pl bug fix Andrew Murray
2011-06-10 13:00 ` Jiri Kosina [this message]
2011-06-11 3:21 ` Arjan van de Ven
2011-06-12 22:05 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1106101459570.22872@pobox.suse.cz \
--to=jkosina@suse.cz \
--cc=amurray@mpc-data.co.uk \
--cc=amurray@mpcdata.com \
--cc=arjan@infradead.org \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).