From: Nicolas Pitre <nicolas.pitre@linaro.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-embedded@vger.kernel.org,
linux-kernel@vger.kernel.org,
Chris Brandt <Chris.Brandt@renesas.com>,
linux-mm@kvack.org
Subject: Re: [PATCH v3 4/5] cramfs: add mmap support
Date: Thu, 31 Aug 2017 13:52:35 -0400 (EDT) [thread overview]
Message-ID: <nycvar.YSQ.7.76.1708311343060.2606@knanqh.ubzr> (raw)
In-Reply-To: <20170831092338.GA8196@infradead.org>
On Thu, 31 Aug 2017, Christoph Hellwig wrote:
> The whole VMA games here look entirely bogus you can't just drop
> and reacquire mmap_sem for example.
> And splitting vmas looks just
> as promblematic.
I didn't just decide to do that on a whim. I spent quite some time
looking at page fault code paths and make sure it is fine to reaquire
the lock. There are existing code paths that drop the lock entirely and
return with no locks so this is already expected by the core code.
> As a minimum you really must see the linux-mm list can get some
> feedback there.
Good point. You added linux-mm to CC so I'll wait for their comments.
Nicolas
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-08-31 17:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 3:09 [GIT PULL / PATCH v3 0/5] cramfs refresh for embedded usage Nicolas Pitre
2017-08-31 3:09 ` [PATCH v3 1/5] cramfs: direct memory access support Nicolas Pitre
2017-08-31 3:09 ` [PATCH v3 2/5] cramfs: make cramfs_physmem usable as root fs Nicolas Pitre
2017-08-31 3:09 ` [PATCH v3 3/5] cramfs: implement uncompressed and arbitrary data block positioning Nicolas Pitre
2017-08-31 3:09 ` [PATCH v3 4/5] cramfs: add mmap support Nicolas Pitre
2017-08-31 9:23 ` Christoph Hellwig
2017-08-31 17:52 ` Nicolas Pitre [this message]
2017-08-31 3:09 ` [PATCH v3 5/5] cramfs: rehabilitate it Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YSQ.7.76.1708311343060.2606@knanqh.ubzr \
--to=nicolas.pitre@linaro.org \
--cc=Chris.Brandt@renesas.com \
--cc=hch@infradead.org \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).