From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Mike Baynton <mike@mbaynton.com>, linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH v2] erofs-utils: mkfs: Support tar source without data
Date: Tue, 27 Feb 2024 23:36:04 +0800 [thread overview]
Message-ID: <55d8b3a9-9130-4e6a-9aef-006f72d26b7f@linux.alibaba.com> (raw)
In-Reply-To: <CAM56kJTvu7cQZmK5-6SKb=ObkHsYtG663gsRQOAndj=3UY-aaQ@mail.gmail.com>
On 2024/2/27 23:22, Mike Baynton wrote:
> On Tue, Feb 27, 2024 at 2:42 AM Gao Xiang <hsiangkao@linux.alibaba.com> wrote:
>>
>> Hi Mike,
>> Just some minor changes for applying to -dev development codebase.
>> Does it look good to you?
>> (I will apply this version to -experimental for testing.)
>
> Looks pretty good to me, thank you! Looks like I should have created
> the patch against -dev.
>
> This modifies the --help text and includes tar twice, was that intentional?
>
> --tar=X generate a full or index-only image from a
> tarball(-ish) source
> (X = f|i|headerball; f=full mode, i=index mode,
> headerball=file data is
> omited in the source stream)
> --tar=[fi] generate an image from tarball(s)
Ah, very sorry about that. And thanks for catching this,
let me drop the redundant one directly.
Thanks,
Gao Xiang
prev parent reply other threads:[~2024-02-27 15:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 5:11 [PATCH] erofs-utils: mkfs: Support tar source without data Mike Baynton
2024-02-27 5:43 ` Gao Xiang
2024-02-27 8:42 ` [PATCH v2] " Gao Xiang
2024-02-27 15:22 ` Mike Baynton
2024-02-27 15:36 ` Gao Xiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55d8b3a9-9130-4e6a-9aef-006f72d26b7f@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=mike@mbaynton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).