From: Thomas Zimmermann <tzimmermann@suse.de>
To: Michael Ellerman <mpe@ellerman.id.au>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Jani Nikula <jani.nikula@intel.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Cc: "linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
Helge Deller <deller@gmx.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lkft-triage@lists.linaro.org" <lkft-triage@lists.linaro.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Naresh Kamboju <naresh.kamboju@linaro.org>
Subject: Re: [PATCH] powerpc: include linux/backlight.h from asm/backlight.h
Date: Tue, 5 Mar 2024 09:09:42 +0100 [thread overview]
Message-ID: <01d39b0d-ce72-4daa-8628-f47e031af5ca@suse.de> (raw)
In-Reply-To: <87frx5plan.fsf@mail.lhotse>
Hi
Am 05.03.24 um 01:36 schrieb Michael Ellerman:
> Christophe Leroy <christophe.leroy@csgroup.eu> writes:
>> Le 04/03/2024 à 11:32, Thomas Zimmermann a écrit :
>>> Hi
>>>
>>> Am 04.03.24 um 10:55 schrieb Jani Nikula:
>>>> Removal of the backlight include from fb.h uncovered an implicit
>>>> dependency in powerpc asm/backlight.h. Add the explicit include.
>>>>
>>>> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
>>>> Closes:
>>>> https://lore.kernel.org/r/CA+G9fYsAk5TbqqxFC2W4oHLGA0CbTHMxbeq8QayFXTU75YiueA@mail.gmail.com
>>>> Fixes: 11b4eedfc87d ("fbdev: Do not include <linux/backlight.h> in
>>>> header")
>>>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>>>> Cc: Helge Deller <deller@gmx.de>
>>>> Cc: linux-fbdev@vger.kernel.org
>>>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>>>
>>>> ---
>>>>
>>>> Not even compile tested!
>>> That's one of the cases that's hard to catch unless you get the config
>>> right.
>>>
>>>> ---
>>>> arch/powerpc/include/asm/backlight.h | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/arch/powerpc/include/asm/backlight.h
>>>> b/arch/powerpc/include/asm/backlight.h
>>>> index 1b5eab62ed04..275d5bb9aa04 100644
>>>> --- a/arch/powerpc/include/asm/backlight.h
>>>> +++ b/arch/powerpc/include/asm/backlight.h
>>>> @@ -10,6 +10,7 @@
>>>> #define __ASM_POWERPC_BACKLIGHT_H
>>>> #ifdef __KERNEL__
>>>> +#include <linux/backlight.h>
>>> Thanks, but I think this should go directly into chipsfb.c. I would have
>>> provided a patch already, if our mail server didn't have issues this
>>> morning. Let me try again.
>> asm/backlight.h needs it for struct backlight_device
>>
>> At least if you don't want to include linux/backlight.h in
>> asm/backlight.h, then you need a forward declaration of struct
>> backlight_device;
> It's preferable for asm headers not to include linux headers (to avoid
> loops), so a forward declaration would be better IMHO.
The asm header shouldn't include <linux/fb.h> either. I'll send an
update to my patch to clean up everything.
Best regards
Thomas
>
> cheers
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
prev parent reply other threads:[~2024-03-05 8:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 8:20 fbdev/chipsfb.c:401:31: error: invalid use of undefined type 'struct backlight_device' Naresh Kamboju
2024-03-04 9:55 ` [PATCH] powerpc: include linux/backlight.h from asm/backlight.h Jani Nikula
2024-03-04 10:01 ` Jani Nikula
2024-03-04 14:55 ` Naresh Kamboju
2024-03-05 0:39 ` Michael Ellerman
2024-03-05 8:19 ` Jani Nikula
2024-03-04 10:32 ` Thomas Zimmermann
2024-03-04 10:40 ` Thomas Zimmermann
2024-03-04 18:13 ` Christophe Leroy
2024-03-05 0:36 ` Michael Ellerman
2024-03-05 8:09 ` Thomas Zimmermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01d39b0d-ce72-4daa-8628-f47e031af5ca@suse.de \
--to=tzimmermann@suse.de \
--cc=christophe.leroy@csgroup.eu \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkft-triage@lists.linaro.org \
--cc=mpe@ellerman.id.au \
--cc=naresh.kamboju@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).