From: Nikita Kiryushin <kiryushin@ancud.ru>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Teddy Wang <teddy.wang@siliconmotion.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
Subject: [PATCH] staging: sm750fb: Remove unneeded setting of info->screen_size
Date: Fri, 1 Mar 2024 22:53:29 +0300 [thread overview]
Message-ID: <1d6c298a-81d5-4ffd-becb-3a796690f4be@ancud.ru> (raw)
In-Reply-To: <>
In lynxfb_set_fbinfo info->screen_size is set twice, the first value is
never used and then overwritten.
Remove the first time the value is set.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: 81dee67e215b ("staging: sm750fb: add sm750 to staging")
Signed-off-by: Nikita Kiryushin <kiryushin@ancud.ru>
---
drivers/staging/sm750fb/sm750.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750.c
b/drivers/staging/sm750fb/sm750.c
index 04c1b32a22c5..70d1c8292df0 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -845,7 +845,6 @@ static int lynxfb_set_fbinfo(struct fb_info *info,
int index)
info->pseudo_palette = &par->pseudo_palette[0];
info->screen_base = crtc->v_screen;
pr_debug("screen_base vaddr = %p\n", info->screen_base);
- info->screen_size = line_length * var->yres_virtual;
/* set info->fix */
fix->type = FB_TYPE_PACKED_PIXELS;
--
2.34.1
reply other threads:[~2024-03-01 20:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d6c298a-81d5-4ffd-becb-3a796690f4be@ancud.ru \
--to=kiryushin@ancud.ru \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lvc-project@linuxtesting.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).