From: Lee Jones <lee@kernel.org>
To: "Duje Mihanović" <duje.mihanovic@skole.hr>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>, Pavel Machek <pavel@ucw.cz>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Helge Deller <deller@gmx.de>,
Linus Walleij <linus.walleij@linaro.org>,
Karel Balej <balejk@matfyz.cz>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v4 1/3] leds: ktd2692: move ExpressWire code to library
Date: Thu, 25 Jan 2024 13:44:58 +0000 [thread overview]
Message-ID: <20240125134458.GK74950@google.com> (raw)
In-Reply-To: <20240122-ktd2801-v4-1-33c986a3eb68@skole.hr>
On Mon, 22 Jan 2024, Duje Mihanović wrote:
> The ExpressWire protocol is shared between at least KTD2692 and KTD2801
> with slight differences such as timings and the former not having a
> defined set of pulses for enabling the protocol (possibly because it
> does not support PWM unlike KTD2801). Despite these differences the
> ExpressWire handling code can be shared between the two, so move it into
> a library in preparation for adding KTD2801 support.
>
> Suggested-by: Daniel Thompson <daniel.thompson@linaro.org>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>
> ---
> MAINTAINERS | 7 +++
> drivers/leds/Kconfig | 4 ++
> drivers/leds/Makefile | 3 +
> drivers/leds/flash/Kconfig | 2 +-
> drivers/leds/flash/leds-ktd2692.c | 116 +++++++++-----------------------------
> drivers/leds/leds-expresswire.c | 68 ++++++++++++++++++++++
> include/linux/leds-expresswire.h | 36 ++++++++++++
Please can you separate the Expresswire addition into its own patch?
> 7 files changed, 146 insertions(+), 90 deletions(-)
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-01-25 13:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 19:50 [PATCH v4 0/3] Kinetic ExpressWire library and KTD2801 backlight driver Duje Mihanović
2024-01-22 19:50 ` [PATCH v4 1/3] leds: ktd2692: move ExpressWire code to library Duje Mihanović
2024-01-23 17:20 ` Daniel Thompson
2024-01-25 13:44 ` Lee Jones [this message]
2024-01-22 19:50 ` [PATCH v4 2/3] dt-bindings: backlight: add Kinetic KTD2801 binding Duje Mihanović
2024-01-23 17:20 ` Daniel Thompson
2024-01-22 19:50 ` [PATCH v4 3/3] backlight: Add Kinetic KTD2801 backlight support Duje Mihanović
2024-01-23 17:22 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240125134458.GK74950@google.com \
--to=lee@kernel.org \
--cc=balejk@matfyz.cz \
--cc=conor+dt@kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=duje.mihanovic@skole.hr \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).