From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: "Sakari Ailus" <sakari.ailus@iki.fi>,
"Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Daniel Vetter" <daniel@ffwll.ch>,
"David Airlie" <airlied@gmail.com>,
"Frank Rowand" <frowand.list@gmail.com>,
"Helge Deller" <deller@gmx.de>,
"Jaroslav Kysela" <perex@perex.cz>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Mark Brown" <broonie@kernel.org>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Maxime Ripard" <mripard@kernel.org>,
"Michal Simek" <michal.simek@amd.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Saravana Kannan" <saravanak@google.com>,
"Takashi Iwai" <tiwai@suse.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-fbdev@vger.kernel.org, linux-media@vger.kernel.org,
linux-sound@vger.kernel.org
Subject: Re: [PATCH v2 00/13] of: property: add port base loop
Date: Mon, 5 Feb 2024 11:26:44 +0200 [thread overview]
Message-ID: <20240205092644.GK6804@pendragon.ideasonboard.com> (raw)
In-Reply-To: <87ttmncw9f.wl-kuninori.morimoto.gx@renesas.com>
Hello Morimoto-san,
On Mon, Feb 05, 2024 at 05:31:25AM +0000, Kuninori Morimoto wrote:
>
> Hi Sakari
>
> > > Thank you for your suggestion.
> > > But I'm not familiar with fwnode, and it seems we still need of_*,
> > > I will keep current style (= non fwnode) in v3
> >
> > The fwnode API should be kept in sync with the OF (and other firmware
> > specific) API. Merging your set in its current form would leave fwnode API
> > impaired. Therefore I'd very much prefer to see this set add similar fwnode
> > APIs, too.
>
> I will keep current fwnode API behavior, but I can't test it.
The fwnode API is an abstraction layer on top of the OF or ACPI APIs,
and allows drivers to work on both without needing to support OF and
ACPI explicitly and separately. You should be able to convert the
drivers you're using to the fwnode API, and it should work exactly the
same as when using the OF-specific functions. That will give you a way
to test the API.
For instance, if you look at the drivers/media/platform/rcar_drif.c
driver, you will see
if (!fwnode_property_read_u32(fwnode, "sync-active", &val))
which, on OF platforms, is equivalent to
if (!of_property_read_u32(np, "sync-active", &val))
This particular driver will never be used on an ACPI-based system, but
drivers are still encouraged to use the fwnode API.
> Now, I'm separating the patch-set into small stages.
> There is no problem for a while, but I think I will ask you to test it in the
> final stage.
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2024-02-05 9:26 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 0:54 [PATCH v2 00/13] of: property: add port base loop Kuninori Morimoto
2024-01-29 0:54 ` [PATCH v2 01/13] " Kuninori Morimoto
2024-01-29 12:16 ` Tomi Valkeinen
2024-01-31 18:52 ` Rob Herring
2024-01-31 23:25 ` Kuninori Morimoto
2024-01-31 18:59 ` Rob Herring
2024-01-29 0:54 ` [PATCH v2 02/13] of: property: use of_graph_get_next_port() on of_graph_get_next_endpoint() Kuninori Morimoto
2024-01-29 12:18 ` Tomi Valkeinen
2024-01-29 0:54 ` [PATCH v2 03/13] of: property: add of_graph_get_next_endpoint_raw() Kuninori Morimoto
2024-01-29 12:29 ` Tomi Valkeinen
2024-01-29 13:02 ` Laurent Pinchart
2024-01-30 0:08 ` Kuninori Morimoto
2024-01-31 18:43 ` Rob Herring
2024-02-01 0:43 ` Kuninori Morimoto
2024-02-01 1:48 ` Kuninori Morimoto
2024-01-29 13:37 ` Sakari Ailus
2024-01-30 0:37 ` Kuninori Morimoto
2024-01-29 0:55 ` [PATCH v2 04/13] drm: omapdrm: use of_graph_get_next_endpoint_raw() Kuninori Morimoto
2024-01-29 0:55 ` [PATCH v2 05/13] media: xilinx-tpg: " Kuninori Morimoto
2024-01-30 13:35 ` kernel test robot
2024-01-29 0:55 ` [PATCH v2 06/13] ASoC: audio-graph-card: " Kuninori Morimoto
2024-01-29 0:55 ` [PATCH v2 07/13] ASoC: audio-graph-card2: use of_graph_get_next_port() Kuninori Morimoto
2024-01-29 0:55 ` [PATCH v2 08/13] ASoC: audio-graph-card2: use of_graph_get_next_endpoint_raw() Kuninori Morimoto
2024-01-29 0:55 ` [PATCH v2 09/13] ASoC: test-component: use for_each_port_of_node() Kuninori Morimoto
2024-01-29 0:55 ` [PATCH v2 10/13] fbdev: omapfb: use of_graph_get_remote_port() Kuninori Morimoto
2024-01-29 0:55 ` [PATCH v2 11/13] fbdev: omapfb: use of_graph_get_next_port() Kuninori Morimoto
2024-01-29 0:55 ` [PATCH v2 12/13] fbdev: omapfb: use of_graph_get_next_endpoint_raw() Kuninori Morimoto
2024-01-29 0:55 ` [PATCH v2 13/13] fbdev: omapfb: use of_graph_get_next_endpoint() Kuninori Morimoto
2024-01-29 12:27 ` [PATCH v2 00/13] of: property: add port base loop Laurent Pinchart
2024-01-29 13:29 ` Sakari Ailus
2024-01-30 0:34 ` Kuninori Morimoto
2024-01-30 7:31 ` Sakari Ailus
2024-01-30 7:37 ` Tomi Valkeinen
2024-01-30 7:40 ` Sakari Ailus
2024-01-30 23:24 ` Kuninori Morimoto
2024-02-01 9:18 ` Sakari Ailus
2024-02-05 5:31 ` Kuninori Morimoto
2024-02-05 9:26 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240205092644.GK6804@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mchehab@kernel.org \
--cc=michal.simek@amd.com \
--cc=mripard@kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=saravanak@google.com \
--cc=tiwai@suse.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).