From: Tony Lindgren <tony@atomide.com>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Helge Deller <deller@gmx.de>,
Javier Martinez Canillas <javierm@redhat.com>,
Sam Ravnborg <sam@ravnborg.org>
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Subject: [PATCH v3 0/2] Fixes for omapdrm console
Date: Wed, 28 Feb 2024 08:35:30 +0200 [thread overview]
Message-ID: <20240228063540.4444-1-tony@atomide.com> (raw)
Here are two fixes for omapdrm for missing drm_framebuffer_funcs.dirty
that needs to be paired with omap_framebuffer_dirty(), and to add
FB_GEN_DEFAULT_DEFERRED_DMAMEM_OPS so things behave as earlier with
drm_fb_helper_sys_write(). Without these fixes, the console won't update
for the command mode displays. And likely mmap() using writes can miss
updates as noted by Thomas.
Regards,
Tony
Changes since v2:
- Fix cache issue noted by Tomi using custom omap_fbdev_fb_mmap() as
suggested by Thomas
- Add FB_DMAMEM_HELPERS_DEFERRED Kconfig option and use it for omapdrm
as noted by Thomas
Changes since v1:
- Add FB_GEN_DEFAULT_DEFERRED_DMAMEM_OPS to use with
FB_DEFAULT_DEFERRED_OPS as suggested by Thomas
Tony Lindgren (2):
drm/omapdrm: Fix console by implementing fb_dirty
drm/omapdrm: Fix console with deferred ops
drivers/gpu/drm/omapdrm/Kconfig | 2 +-
drivers/gpu/drm/omapdrm/omap_fbdev.c | 40 +++++++++++++++++++++++-----
drivers/video/fbdev/core/Kconfig | 6 +++++
include/linux/fb.h | 4 +++
4 files changed, 45 insertions(+), 7 deletions(-)
--
2.43.1
next reply other threads:[~2024-02-28 6:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 6:35 Tony Lindgren [this message]
2024-02-28 6:35 ` [PATCH v3 1/2] drm/omapdrm: Fix console by implementing fb_dirty Tony Lindgren
2024-02-28 6:35 ` [PATCH v3 2/2] drm/omapdrm: Fix console with deferred ops Tony Lindgren
2024-03-18 11:45 ` [PATCH v3 0/2] Fixes for omapdrm console Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240228063540.4444-1-tony@atomide.com \
--to=tony@atomide.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=sam@ravnborg.org \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).