From: Lee Jones <lee@kernel.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: andy@kernel.org, daniel.thompson@linaro.org,
jingoohan1@gmail.com, deller@gmx.de, robin@protonic.nl,
javierm@redhat.com, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org, linux-input@vger.kernel.org,
linux-pwm@vger.kernel.org
Subject: Re: [PATCH v3 00/10] backlight: Replace struct fb_info in interfaces
Date: Tue, 5 Mar 2024 10:44:59 +0000 [thread overview]
Message-ID: <20240305104459.GA86322@google.com> (raw)
In-Reply-To: <20240304163220.19144-1-tzimmermann@suse.de>
On Mon, 04 Mar 2024, Thomas Zimmermann wrote:
> Backlight drivers implement struct backlight_ops.check_fb, which
> uses struct fb_info in its interface. Replace the callback with one
> that does not use fb_info.
>
> In DRM, we have several drivers that implement backlight support. By
> including <linux/backlight.h> these drivers depend on <linux/fb.h>.
> At the same time, fbdev is deprecated for new drivers and likely to
> be replaced on many systems.
>
> This patchset is part of a larger effort to implement the backlight
> code without depending on fbdev.
>
> Patch 1 makes the backlight core match backlight and framebuffer
> devices via struct fb_info.bl_dev. Patches 2 to 9 then go through
> drivers and remove unnecessary implementations of check_fb. Finally,
> patch 10 replaces the check_fb hook with controls_device, which
> uses the framebuffer's Linux device instead of the framebuffer.
>
> v3:
> * hide CONFIG_FB_BACKLIGHT behind fb_bl_device() (Lee)
> * if-else cleanups (Andy)
> * fix commit message of patch 2 (Andy)
> v2:
> * fix hid-picolcd for CONFIG_FB_BACKLIGHT=n
> * fixes to commit messages
>
> Thomas Zimmermann (10):
> backlight: Match backlight device against struct fb_info.bl_dev
> auxdisplay/ht16k33: Remove struct backlight_ops.check_fb
> hid/hid-picolcd: Fix initialization order
> hid/hid-picolcd: Remove struct backlight_ops.check_fb
> backlight/aat2870-backlight: Remove struct backlight.check_fb
> backlight/pwm-backlight: Remove struct backlight_ops.check_fb
> fbdev/sh_mobile_lcdc_fb: Remove struct backlight_ops.check_fb
> fbdev/ssd1307fb: Init backlight before registering framebuffer
> fbdev/ssd1307fb: Remove struct backlight_ops.check_fb
> backlight: Add controls_device callback to struct backlight_ops
>
> drivers/auxdisplay/ht16k33.c | 8 ------
> drivers/hid/hid-picolcd_backlight.c | 7 ------
> drivers/hid/hid-picolcd_core.c | 14 +++++------
> drivers/hid/hid-picolcd_fb.c | 6 +++++
> drivers/video/backlight/aat2870_bl.c | 7 ------
> drivers/video/backlight/backlight.c | 8 ++++--
> drivers/video/backlight/bd6107.c | 12 ++++-----
> drivers/video/backlight/gpio_backlight.c | 12 ++++-----
> drivers/video/backlight/lv5207lp.c | 12 ++++-----
> drivers/video/backlight/pwm_bl.c | 12 ---------
> drivers/video/fbdev/core/fb_backlight.c | 5 ++++
> drivers/video/fbdev/sh_mobile_lcdcfb.c | 7 ------
> drivers/video/fbdev/ssd1307fb.c | 31 +++++++++---------------
> include/linux/backlight.h | 16 ++++++------
> include/linux/fb.h | 9 +++++++
> include/linux/pwm_backlight.h | 1 -
> 16 files changed, 70 insertions(+), 97 deletions(-)
All applied. Submitted for build testing.
Will follow-up with a PR once that's passed.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-03-05 10:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 16:29 [PATCH v3 00/10] backlight: Replace struct fb_info in interfaces Thomas Zimmermann
2024-03-04 16:29 ` [PATCH v3 01/10] backlight: Match backlight device against struct fb_info.bl_dev Thomas Zimmermann
2024-03-04 16:29 ` [PATCH v3 02/10] auxdisplay/ht16k33: Remove struct backlight_ops.check_fb Thomas Zimmermann
2024-03-04 16:29 ` [PATCH v3 03/10] hid/hid-picolcd: Fix initialization order Thomas Zimmermann
2024-03-04 16:29 ` [PATCH v3 04/10] hid/hid-picolcd: Remove struct backlight_ops.check_fb Thomas Zimmermann
2024-03-04 16:29 ` [PATCH v3 05/10] backlight/aat2870-backlight: Remove struct backlight.check_fb Thomas Zimmermann
2024-03-04 16:29 ` [PATCH v3 06/10] backlight/pwm-backlight: Remove struct backlight_ops.check_fb Thomas Zimmermann
2024-03-04 16:29 ` [PATCH v3 07/10] fbdev/sh_mobile_lcdc_fb: " Thomas Zimmermann
2024-03-04 16:29 ` [PATCH v3 08/10] fbdev/ssd1307fb: Init backlight before registering framebuffer Thomas Zimmermann
2024-03-04 16:29 ` [PATCH v3 09/10] fbdev/ssd1307fb: Remove struct backlight_ops.check_fb Thomas Zimmermann
2024-03-04 16:29 ` [PATCH v3 10/10] backlight: Add controls_device callback to struct backlight_ops Thomas Zimmermann
2024-03-05 9:36 ` [PATCH v3 00/10] backlight: Replace struct fb_info in interfaces Lee Jones
2024-03-05 10:00 ` Thomas Zimmermann
2024-03-05 10:30 ` Lee Jones
2024-03-05 10:44 ` Lee Jones [this message]
2024-03-05 14:53 ` Lee Jones
2024-03-05 16:04 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240305104459.GA86322@google.com \
--to=lee@kernel.org \
--cc=andy@kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=jingoohan1@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robin@protonic.nl \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).