From: Thomas Zimmermann <tzimmermann@suse.de>
To: lee@kernel.org, daniel.thompson@linaro.org, jingoohan1@gmail.com,
deller@gmx.de
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 4/6] fbdev/omap2/omapfb: Replace use of fb_blank with backlight helpers
Date: Wed, 13 Mar 2024 16:45:03 +0100 [thread overview]
Message-ID: <20240313154857.12949-5-tzimmermann@suse.de> (raw)
In-Reply-To: <20240313154857.12949-1-tzimmermann@suse.de>
Replace the use of struct backlight_properties.fb_blank with backlight
helpers. This effects testing if the backlight is blanked and reading
the backlight's brightness level.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c | 6 +-----
.../fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c | 9 ++-------
2 files changed, 3 insertions(+), 12 deletions(-)
diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c b/drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c
index adb8881bac285..47683a6c00767 100644
--- a/drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c
+++ b/drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c
@@ -356,11 +356,7 @@ static int dsicm_bl_update_status(struct backlight_device *dev)
static int dsicm_bl_get_intensity(struct backlight_device *dev)
{
- if (dev->props.fb_blank == FB_BLANK_UNBLANK &&
- dev->props.power == FB_BLANK_UNBLANK)
- return dev->props.brightness;
-
- return 0;
+ return backlight_get_brightness(dev);
}
static const struct backlight_ops dsicm_bl_ops = {
diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c b/drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c
index 685c63aa4e030..9d3ce234a7874 100644
--- a/drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c
+++ b/drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c
@@ -340,11 +340,7 @@ static int acx565akm_bl_update_status(struct backlight_device *dev)
dev_dbg(&ddata->spi->dev, "%s\n", __func__);
- if (dev->props.fb_blank == FB_BLANK_UNBLANK &&
- dev->props.power == FB_BLANK_UNBLANK)
- level = dev->props.brightness;
- else
- level = 0;
+ level = backlight_get_brightness(dev);
if (ddata->has_bc)
acx565akm_set_brightness(ddata, level);
@@ -363,8 +359,7 @@ static int acx565akm_bl_get_intensity(struct backlight_device *dev)
if (!ddata->has_bc)
return -ENODEV;
- if (dev->props.fb_blank == FB_BLANK_UNBLANK &&
- dev->props.power == FB_BLANK_UNBLANK) {
+ if (!backlight_is_blank(dev)) {
if (ddata->has_bc)
return acx565akm_get_actual_brightness(ddata);
else
--
2.44.0
next prev parent reply other threads:[~2024-03-13 15:49 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 15:44 [PATCH 0/6] backlight: Remove struct backlight_properties.fb_blank Thomas Zimmermann
2024-03-13 15:45 ` [PATCH 1/6] auxdisplay/ht16k33: Replace use of fb_blank with backlight helper Thomas Zimmermann
2024-03-13 16:08 ` Miguel Ojeda
2024-03-13 17:11 ` Dan Carpenter
2024-03-13 17:44 ` Miguel Ojeda
2024-03-13 17:54 ` Sam Ravnborg
2024-03-14 18:44 ` Miguel Ojeda
2024-03-14 8:09 ` Thomas Zimmermann
2024-03-14 18:44 ` Miguel Ojeda
2024-03-13 17:34 ` Dan Carpenter
2024-03-13 18:01 ` Sam Ravnborg
2024-03-14 8:34 ` Geert Uytterhoeven
2024-03-18 9:06 ` Robin van der Gracht
2024-03-13 15:45 ` [PATCH 2/6] backlight/omap1-bl: Remove unused struct omap_backlight_config.set_power Thomas Zimmermann
2024-03-13 16:33 ` Lee Jones
2024-03-13 18:02 ` Sam Ravnborg
2024-03-18 11:45 ` Daniel Thompson
2024-03-13 15:45 ` [PATCH 3/6] backlight/omap1-bl: Replace FB_BLANK_ states with simple on/off Thomas Zimmermann
2024-03-13 18:00 ` Sam Ravnborg
2024-03-14 8:16 ` Thomas Zimmermann
2024-03-14 8:57 ` Sam Ravnborg
2024-03-14 9:53 ` Dan Carpenter
2024-03-18 12:06 ` Daniel Thompson
2024-03-13 15:45 ` Thomas Zimmermann [this message]
2024-03-13 15:45 ` [PATCH 5/6] staging/fbtft: Remove reference to fb_blank Thomas Zimmermann
2024-03-13 17:33 ` Dan Carpenter
2024-03-13 15:45 ` [PATCH 6/6] backlight: Remove fb_blank from struct backlight_properties Thomas Zimmermann
2024-03-14 12:48 ` FLAVIO SULIGOI
2024-03-18 12:08 ` Daniel Thompson
2024-03-13 17:36 ` [PATCH 0/6] backlight: Remove struct backlight_properties.fb_blank Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240313154857.12949-5-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).