From: Chandra Pratap <chandrapratap3519@gmail.com>
To: outreachy@lists.linux.dev
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org,
staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Chandra Pratap <chandrapratap3519@gmail.com>
Subject: [PATCH] staging: sm750fb: Replace comparisons with NULL and 0
Date: Fri, 15 Mar 2024 18:31:11 +0530 [thread overview]
Message-ID: <20240315130400.11540-1-chandrapratap3519@gmail.com> (raw)
Replace '(foo != NULL)' with '(foo)' and 'x != 0'
with 'x' to adhere to the coding standards.
Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com>
---
drivers/staging/sm750fb/sm750.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 04c1b32a22c5..4537f007a810 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -926,7 +926,7 @@ static void sm750fb_setup(struct sm750_dev *sm750_dev, char *src)
goto NO_PARAM;
}
- while ((opt = strsep(&src, ":")) != NULL && *opt != 0) {
+ while ((opt = strsep(&src, ":")) && *opt) {
dev_info(&sm750_dev->pdev->dev, "opt=%s\n", opt);
dev_info(&sm750_dev->pdev->dev, "src=%s\n", src);
@@ -1147,7 +1147,7 @@ static int __init lynxfb_setup(char *options)
* strsep() updates @options to pointer after the first found token
* it also returns the pointer ahead the token.
*/
- while ((opt = strsep(&options, ":")) != NULL) {
+ while ((opt = strsep(&options, ":"))) {
/* options that mean for any lynx chips are configured here */
if (!strncmp(opt, "noaccel", strlen("noaccel"))) {
g_noaccel = 1;
--
2.43.2
next reply other threads:[~2024-03-15 13:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 13:01 Chandra Pratap [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-03-19 18:17 [PATCH] staging: sm750fb: Replace comparisons with NULL and 0 Chandra Pratap
2024-03-20 5:08 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240315130400.11540-1-chandrapratap3519@gmail.com \
--to=chandrapratap3519@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy@lists.linux.dev \
--cc=staging@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).