From: "Bruno Prémont" <bonbons@sysophe.eu>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Lee Jones <lee@kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>, Helge Deller <deller@gmx.de>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <bentiss@kernel.org>,
Alexander Shiyan <shc_work@mail.ru>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 15/18] HID: picoLCD: Constify lcd_ops
Date: Tue, 16 Apr 2024 10:07:16 +0200 [thread overview]
Message-ID: <20240416100716.7360ec35@pluto.restena.lu> (raw)
In-Reply-To: <20240414-video-backlight-lcd-ops-v1-15-9b37fcbf546a@kernel.org>
On Sun, 14 Apr 2024 18:36:13 +0200 Krzysztof Kozlowski wrote:
> 'struct lcd_ops' is not modified by core backlight code, so it can be
> made const for increased code safety.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Bruno Prémont <bonbons@linux-vserver.org>
> ---
>
> Depends on the first patch in the series.
> ---
> drivers/hid/hid-picolcd_lcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-picolcd_lcd.c b/drivers/hid/hid-picolcd_lcd.c
> index 0c4b76de8ae5..061a33ba7b1d 100644
> --- a/drivers/hid/hid-picolcd_lcd.c
> +++ b/drivers/hid/hid-picolcd_lcd.c
> @@ -46,7 +46,7 @@ static int picolcd_check_lcd_fb(struct lcd_device *ldev, struct fb_info *fb)
> return fb && fb == picolcd_fbinfo((struct picolcd_data *)lcd_get_data(ldev));
> }
>
> -static struct lcd_ops picolcd_lcdops = {
> +static const struct lcd_ops picolcd_lcdops = {
> .get_contrast = picolcd_get_contrast,
> .set_contrast = picolcd_set_contrast,
> .check_fb = picolcd_check_lcd_fb,
>
next prev parent reply other threads:[~2024-04-16 8:14 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 16:35 [PATCH 00/18] backlight: Constify lcd_ops Krzysztof Kozlowski
2024-04-14 16:35 ` [PATCH 01/18] " Krzysztof Kozlowski
2024-04-15 12:46 ` Daniel Thompson
2024-04-14 16:36 ` [PATCH 02/18] backlight: ams369fg06: " Krzysztof Kozlowski
2024-04-15 12:47 ` Daniel Thompson
2024-04-14 16:36 ` [PATCH 03/18] backlight: corgi_lcd: " Krzysztof Kozlowski
2024-04-15 12:48 ` Daniel Thompson
2024-04-14 16:36 ` [PATCH 04/18] backlight: hx8357: " Krzysztof Kozlowski
2024-04-15 12:49 ` Daniel Thompson
2024-04-14 16:36 ` [PATCH 05/18] backlight: ili922x: " Krzysztof Kozlowski
2024-04-15 12:49 ` Daniel Thompson
2024-04-14 16:36 ` [PATCH 06/18] backlight: ili9320: " Krzysztof Kozlowski
2024-04-15 12:49 ` Daniel Thompson
2024-04-14 16:36 ` [PATCH 07/18] backlight: jornada720_lcd: " Krzysztof Kozlowski
2024-04-15 12:52 ` Daniel Thompson
2024-04-14 16:36 ` [PATCH 08/18] backlight: l4f00242t03: " Krzysztof Kozlowski
2024-04-15 12:53 ` Daniel Thompson
2024-04-14 16:36 ` [PATCH 09/18] backlight: lms283gf05: " Krzysztof Kozlowski
2024-04-15 12:54 ` Daniel Thompson
2024-04-14 16:36 ` [PATCH 10/18] backlight: lms501kf03: " Krzysztof Kozlowski
2024-04-15 12:54 ` Daniel Thompson
2024-04-14 16:36 ` [PATCH 11/18] backlight: ltv350qv: " Krzysztof Kozlowski
2024-04-15 12:54 ` Daniel Thompson
2024-04-14 16:36 ` [PATCH 12/18] backlight: otm3225a: " Krzysztof Kozlowski
2024-04-15 12:54 ` Daniel Thompson
2024-04-14 16:36 ` [PATCH 13/18] backlight: platform_lcd: " Krzysztof Kozlowski
2024-04-15 12:55 ` Daniel Thompson
2024-04-14 16:36 ` [PATCH 14/18] backlight: tdo24m: " Krzysztof Kozlowski
2024-04-15 12:55 ` Daniel Thompson
2024-04-14 16:36 ` [PATCH 15/18] HID: picoLCD: " Krzysztof Kozlowski
2024-04-16 8:07 ` Bruno Prémont [this message]
2024-04-14 16:36 ` [PATCH 16/18] fbdev: clps711x: " Krzysztof Kozlowski
2024-04-14 16:36 ` [PATCH 17/18] fbdev: imx: " Krzysztof Kozlowski
2024-04-14 16:36 ` [PATCH 18/18] fbdev: omap: lcd_ams_delta: " Krzysztof Kozlowski
2024-04-15 6:56 ` [PATCH 00/18] backlight: " Thomas Zimmermann
2024-04-15 7:48 ` Krzysztof Kozlowski
2024-04-16 12:17 ` Lee Jones
2024-04-15 12:58 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240416100716.7360ec35@pluto.restena.lu \
--to=bonbons@sysophe.eu \
--cc=bentiss@kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jikos@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).