* [RESEND][PATCH v3][next] backlight: sky81452-backlight: Remove unnecessary call to of_node_get
@ 2024-05-02 17:21 Shresth Prasad
2024-05-02 17:26 ` (subset) " Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Shresth Prasad @ 2024-05-02 17:21 UTC (permalink / raw
To: lee, daniel.thompson, jingoohan1, deller
Cc: dri-devel, linux-fbdev, linux-kernel, javier.carrasco.cruz, skhan,
julia.lawall, Shresth Prasad
`dev->of_node` already has a reference to the device_node and calling
of_node_get on it is unnecessary. All conresponding calls to
of_node_put are also removed.
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Shresth Prasad <shresthprasad7@gmail.com>
---
Changes in v3:
- Remove unnecessary braces
drivers/video/backlight/sky81452-backlight.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/video/backlight/sky81452-backlight.c b/drivers/video/backlight/sky81452-backlight.c
index eb18c6eb0ff0..19f9f84a9fd6 100644
--- a/drivers/video/backlight/sky81452-backlight.c
+++ b/drivers/video/backlight/sky81452-backlight.c
@@ -182,7 +182,7 @@ static const struct attribute_group sky81452_bl_attr_group = {
static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
struct device *dev)
{
- struct device_node *np = of_node_get(dev->of_node);
+ struct device_node *np = dev->of_node;
struct sky81452_bl_platform_data *pdata;
int num_entry;
unsigned int sources[6];
@@ -194,10 +194,8 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
}
pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
- if (!pdata) {
- of_node_put(np);
+ if (!pdata)
return ERR_PTR(-ENOMEM);
- }
of_property_read_string(np, "name", &pdata->name);
pdata->ignore_pwm = of_property_read_bool(np, "skyworks,ignore-pwm");
@@ -217,7 +215,6 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
num_entry);
if (ret < 0) {
dev_err(dev, "led-sources node is invalid.\n");
- of_node_put(np);
return ERR_PTR(-EINVAL);
}
@@ -237,7 +234,6 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
if (ret < 0)
pdata->boost_current_limit = 2750;
- of_node_put(np);
return pdata;
}
#else
--
2.45.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: (subset) [RESEND][PATCH v3][next] backlight: sky81452-backlight: Remove unnecessary call to of_node_get
2024-05-02 17:21 [RESEND][PATCH v3][next] backlight: sky81452-backlight: Remove unnecessary call to of_node_get Shresth Prasad
@ 2024-05-02 17:26 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2024-05-02 17:26 UTC (permalink / raw
To: lee, daniel.thompson, jingoohan1, deller, Shresth Prasad
Cc: dri-devel, linux-fbdev, linux-kernel, javier.carrasco.cruz, skhan,
julia.lawall
On Thu, 02 May 2024 22:51:21 +0530, Shresth Prasad wrote:
> `dev->of_node` already has a reference to the device_node and calling
> of_node_get on it is unnecessary. All conresponding calls to
> of_node_put are also removed.
>
>
Applied, thanks!
[1/1] backlight: sky81452-backlight: Remove unnecessary call to of_node_get
commit: 4da294108e38bf9cd5c62c2caa47611e5dbb7fb1
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-02 17:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-02 17:21 [RESEND][PATCH v3][next] backlight: sky81452-backlight: Remove unnecessary call to of_node_get Shresth Prasad
2024-05-02 17:26 ` (subset) " Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).