From: "Duje Mihanović" <duje.mihanovic@skole.hr>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Lee Jones <lee@kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>, Pavel Machek <pavel@ucw.cz>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Helge Deller <deller@gmx.de>,
Karel Balej <balejk@matfyz.cz>,
~postmarketos/upstreaming@lists.sr.ht,
dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v2 2/2] backlight: Add Kinetic KTD2801 driver
Date: Fri, 19 Jan 2024 18:36:15 +0100 [thread overview]
Message-ID: <3283558.44csPzL39Z@radijator> (raw)
In-Reply-To: <51576fbb-c7dd-4ee8-a77f-ae7f62b254ab@wanadoo.fr>
On Friday, January 19, 2024 6:29:21 PM CET Christophe JAILLET wrote:
> Le 18/01/2024 à 18:32, Duje Mihanović a écrit :
> > Add driver for the Kinetic KTD2801 backlight driver.
> >
> > Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>
> >
> > ---
>
> ...
>
> > + ktd2801->gpiod = devm_gpiod_get(dev, "ctrl", GPIOD_OUT_HIGH);
> > + if (IS_ERR(ktd2801->gpiod))
> > + return dev_err_probe(dev, PTR_ERR(dev),
>
> PTR_ERR(ktd2801->gpiod); ?
Good catch, I'll fix it in v3.
Regards,
--
Duje
prev parent reply other threads:[~2024-01-19 17:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 17:32 [PATCH v2 0/2] Kinetic KTD2801 backlight driver Duje Mihanović
2024-01-18 17:32 ` [PATCH v2 1/2] dt-bindings: backlight: add Kinetic KTD2801 binding Duje Mihanović
2024-01-19 8:48 ` Linus Walleij
2024-01-18 17:32 ` [PATCH v2 2/2] backlight: Add Kinetic KTD2801 driver Duje Mihanović
2024-01-19 9:02 ` Linus Walleij
2024-01-19 16:36 ` Duje Mihanović
2024-01-19 10:07 ` Daniel Thompson
2024-01-19 16:36 ` Duje Mihanović
2024-01-19 17:29 ` Christophe JAILLET
2024-01-19 17:36 ` Duje Mihanović [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3283558.44csPzL39Z@radijator \
--to=duje.mihanovic@skole.hr \
--cc=balejk@matfyz.cz \
--cc=christophe.jaillet@wanadoo.fr \
--cc=conor+dt@kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).