From: "Duje Mihanović" <duje.mihanovic@skole.hr>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Lee Jones <lee@kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>, Helge Deller <deller@gmx.de>,
Arnd Bergmann <arnd@kernel.org>, Karel Balej <balejk@matfyz.cz>,
dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] backlight: ktd2801: depend on GPIOLIB
Date: Thu, 15 Feb 2024 15:20:50 +0100 [thread overview]
Message-ID: <5772702.DvuYhMxLoT@radijator> (raw)
In-Reply-To: <CACRpkdYm0dNZZvzAZ-VQ+MaHeL7NmGCmCVw42WMx6BFf4Lw0Pw@mail.gmail.com>
On Thursday, February 15, 2024 2:31:37 PM CET Linus Walleij wrote:
> On Tue, Feb 13, 2024 at 7:13 PM Duje Mihanović <duje.mihanovic@skole.hr>
wrote:
> > LEDS_EXPRESSWIRE depends on GPIOLIB, and so must anything selecting it:
> >
> > WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE
> >
> > Depends on [n]: NEW_LEDS [=y] && GPIOLIB [=n]
> > Selected by [m]:
> > - BACKLIGHT_KTD2801 [=m] && HAS_IOMEM [=y] && BACKLIGHT_CLASS_DEVICE
[=m]
> >
> > Fixes: 66c76c1cd984 ("backlight: Add Kinetic KTD2801 backlight support")
> > Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> Technically you can also select GPIOLIB, because it is available on
> all platforms, so it may be easier for users, but then you never know
> which GPIOs you get in practice.
Now that I think of it, wouldn't that be the better solution? I opted for
"depends on" only because Arnd did the same in his KTD2692 patch, but if
select is better (and it seems to be for users) then I'd go for that in both
patches.
Regards,
--
Duje
prev parent reply other threads:[~2024-02-15 14:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 18:12 [PATCH] backlight: ktd2801: depend on GPIOLIB Duje Mihanović
2024-02-15 11:44 ` Daniel Thompson
2024-02-15 13:31 ` Linus Walleij
2024-02-15 14:20 ` Duje Mihanović [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5772702.DvuYhMxLoT@radijator \
--to=duje.mihanovic@skole.hr \
--cc=arnd@kernel.org \
--cc=balejk@matfyz.cz \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).