From: Helge Deller <deller@gmx.de>
To: Michael Ellerman <mpe@ellerman.id.au>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
tzimmermann@suse.de
Subject: Re: [PATCH] fbdev/mb862xxfb: Fix defined but not used error
Date: Fri, 15 Mar 2024 10:02:24 +0100 [thread overview]
Message-ID: <5fccb301-4119-4b26-accb-abc24ade2b0d@gmx.de> (raw)
In-Reply-To: <20240229115010.748435-1-mpe@ellerman.id.au>
On 2/29/24 12:50, Michael Ellerman wrote:
> socrates_gc_mode is defined at the top-level but then only used inside
> an #ifdef CONFIG_FB_MB862XX_LIME, leading to an error with some configs:
>
> drivers/video/fbdev/mb862xx/mb862xxfbdrv.c:36:31: error: ‘socrates_gc_mode’ defined but not used
> 36 | static struct mb862xx_gc_mode socrates_gc_mode = {
>
> Fix it by moving socrates_gc_mode inside that ifdef, immediately prior
> to the only function where it's used.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
applied.
Thanks!
Helge
> ---
> drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c b/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
> index 7c402e9fd7a9..baec312d7b33 100644
> --- a/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
> +++ b/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
> @@ -32,15 +32,6 @@
> #define CARMINE_MEM_SIZE 0x8000000
> #define DRV_NAME "mb862xxfb"
>
> -#if defined(CONFIG_SOCRATES)
> -static struct mb862xx_gc_mode socrates_gc_mode = {
> - /* Mode for Prime View PM070WL4 TFT LCD Panel */
> - { "800x480", 45, 800, 480, 40000, 86, 42, 33, 10, 128, 2, 0, 0, 0 },
> - /* 16 bits/pixel, 16MB, 133MHz, SDRAM memory mode value */
> - 16, 0x1000000, GC_CCF_COT_133, 0x4157ba63
> -};
> -#endif
> -
> /* Helpers */
> static inline int h_total(struct fb_var_screeninfo *var)
> {
> @@ -666,6 +657,15 @@ static int mb862xx_gdc_init(struct mb862xxfb_par *par)
> return 0;
> }
>
> +#if defined(CONFIG_SOCRATES)
> +static struct mb862xx_gc_mode socrates_gc_mode = {
> + /* Mode for Prime View PM070WL4 TFT LCD Panel */
> + { "800x480", 45, 800, 480, 40000, 86, 42, 33, 10, 128, 2, 0, 0, 0 },
> + /* 16 bits/pixel, 16MB, 133MHz, SDRAM memory mode value */
> + 16, 0x1000000, GC_CCF_COT_133, 0x4157ba63
> +};
> +#endif
> +
> static int of_platform_mb862xx_probe(struct platform_device *ofdev)
> {
> struct device_node *np = ofdev->dev.of_node;
prev parent reply other threads:[~2024-03-15 9:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 11:50 [PATCH] fbdev/mb862xxfb: Fix defined but not used error Michael Ellerman
2024-03-15 9:02 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fccb301-4119-4b26-accb-abc24ade2b0d@gmx.de \
--to=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).