From: Michael Ellerman <mpe@ellerman.id.au>
To: Thomas Zimmermann <tzimmermann@suse.de>,
Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org
Cc: Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
"Aneesh Kumar K . V" <aneesh.kumar@kernel.org>,
"Naveen N . Rao" <naveen.n.rao@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org, Geoff Levand <geoff@infradead.org>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] drivers/ps3: select VIDEO to provide cmdline functions
Date: Fri, 09 Feb 2024 16:15:15 +1100 [thread overview]
Message-ID: <8734u28bh8.fsf@mail.lhotse> (raw)
In-Reply-To: <e0893d21-606e-429e-a554-c9ee60fd0ae4@suse.de>
Thomas Zimmermann <tzimmermann@suse.de> writes:
> Am 07.02.24 um 17:13 schrieb Randy Dunlap:
>> When VIDEO is not set, there is a build error. Fix that by selecting
>> VIDEO for PS3_PS3AV.
>>
>> ERROR: modpost: ".video_get_options" [drivers/ps3/ps3av_mod.ko] undefined!
>>
>> Fixes: dae7fbf43fd0 ("driver/ps3: Include <video/cmdline.h> for mode parsing")
>> Fixes: a3b6792e990d ("video/cmdline: Introduce CONFIG_VIDEO for video= parameter")
>> Cc: Michael Ellerman <mpe@ellerman.id.au>
>> Cc: Nicholas Piggin <npiggin@gmail.com>
>> Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
>> Cc: Aneesh Kumar K.V <aneesh.kumar@kernel.org>
>> Cc: Naveen N. Rao <naveen.n.rao@linux.ibm.com>
>> Cc: linuxppc-dev@lists.ozlabs.org
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: Geoff Levand <geoff@infradead.org>
>> Acked-by: Geoff Levand <geoff@infradead.org>
>> Cc: linux-fbdev@vger.kernel.org
>> Cc: dri-devel@lists.freedesktop.org
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Can you take it via whatever tree the CONFIG_VIDEO patch is in?
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
cheers
next prev parent reply other threads:[~2024-02-09 5:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 16:13 [PATCH v2] drivers/ps3: select VIDEO to provide cmdline functions Randy Dunlap
2024-02-07 16:36 ` Thomas Zimmermann
2024-02-09 5:15 ` Michael Ellerman [this message]
2024-02-09 20:24 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734u28bh8.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=aneesh.kumar@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=dri-devel@lists.freedesktop.org \
--cc=geoff@infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=naveen.n.rao@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=rdunlap@infradead.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).