From: Jani Nikula <jani.nikula@intel.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
mpe@ellerman.id.au, naresh.kamboju@linaro.org, deller@gmx.de
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
lkft-triage@lists.linaro.org, linux-kernel@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [PATCH] fbdev/chipsfb: Include <linux/backlight.h>
Date: Mon, 04 Mar 2024 13:16:26 +0200 [thread overview]
Message-ID: <878r2y5jsl.fsf@intel.com> (raw)
In-Reply-To: <20240304103820.16708-1-tzimmermann@suse.de>
On Mon, 04 Mar 2024, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> Fix builds with CONFIG_PMAC_BACKLIGHT=y. The include statement for
> the backlight header has recently been removed from <linux/fb.h>.
>
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Closes: https://lore.kernel.org/dri-devel/CA+G9fYsAk5TbqqxFC2W4oHLGA0CbTHMxbeq8QayFXTU75YiueA@mail.gmail.com/
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Fixes: 11b4eedfc87d ("fbdev: Do not include <linux/backlight.h> in header")
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Helge Deller <deller@gmx.de>
> Cc: linux-fbdev@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
I would've added the include in arch/powerpc/include/asm/backlight.h
[1], but either way is fine by me.
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
[1] https://lore.kernel.org/r/20240304095512.742348-1-jani.nikula@intel.com
> ---
> drivers/video/fbdev/chipsfb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/fbdev/chipsfb.c b/drivers/video/fbdev/chipsfb.c
> index b80711f13df8a..b16a905588fed 100644
> --- a/drivers/video/fbdev/chipsfb.c
> +++ b/drivers/video/fbdev/chipsfb.c
> @@ -15,6 +15,7 @@
> */
>
> #include <linux/aperture.h>
> +#include <linux/backlight.h>
> #include <linux/module.h>
> #include <linux/kernel.h>
> #include <linux/errno.h>
--
Jani Nikula, Intel
prev parent reply other threads:[~2024-03-04 11:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 10:38 [PATCH] fbdev/chipsfb: Include <linux/backlight.h> Thomas Zimmermann
2024-03-04 11:16 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r2y5jsl.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=mpe@ellerman.id.au \
--cc=naresh.kamboju@linaro.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).