From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Rob Herring <robh@kernel.org>
Cc: "Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
"Lad, Prabhakar" <prabhakar.csengg@gmail.com>,
"\"Niklas Söderlund\"" <niklas.soderlund+renesas@ragnatech.se>,
"\"Uwe Kleine-König\"" <u.kleine-koenig@pengutronix.de>,
"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Alexander Stein" <alexander.stein@ew.tq-group.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Alexey Brodkin" <abrodkin@synopsys.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Andy Gross" <agross@kernel.org>,
"Biju Das" <biju.das.jz@bp.renesas.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
"David Airlie" <airlied@gmail.com>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Emma Anholt" <emma@anholt.net>,
"Eugen Hristev" <eugen.hristev@collabora.com>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Frank Rowand" <frowand.list@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Hans Verkuil" <hverkuil-cisco@xs4all.nl>,
"Helge Deller" <deller@gmx.de>,
"Hugues Fruchet" <hugues.fruchet@foss.st.com>,
"Jacopo Mondi" <jacopo+renesas@jmondi.org>,
"Jacopo Mondi" <jacopo@jmondi.org>,
"James Clark" <james.clark@arm.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Kevin Hilman" <khilman@baylibre.com>,
"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
"Kieran Bingham" <kieran.bingham@ideasonboard.com>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Liu Ying" <victor.liu@nxp.com>,
"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Marek Vasut" <marex@denx.de>, "Mark Brown" <broonie@kernel.org>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Michael Tretter" <m.tretter@pengutronix.de>,
"Michal Simek" <michal.simek@amd.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Philippe Cornu" <philippe.cornu@foss.st.com>,
"Raphael Gallais-Pou" <raphael.gallais-pou@foss.st.com>,
"Rob Clark" <robdclark@gmail.com>,
"Robert Foss" <rfoss@kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Saravana Kannan" <saravanak@google.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sowjanya Komatineni" <skomatineni@nvidia.com>,
"Stefan Agner" <stefan@agner.ch>,
"Suzuki K Poulose" <suzuki.poulose@arm.com>,
"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
"Takashi Iwai" <tiwai@suse.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Tim Harvey" <tharvey@gateworks.com>,
"Todor Tomov" <todor.too@gmail.com>,
"Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
"Yannick Fertre" <yannick.fertre@foss.st.com>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Fabio Estevam" <festevam@gmail.com>,
"Jacopo Mondi" <jacopo.mondi@ideasonboard.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Jessica Zhang" <quic_jesszhan@quicinc.com>,
"Jonas Karlman" <jonas@kwiboo.se>, "Leo Yan" <leo.yan@linaro.org>,
"Marijn Suijten" <marijn.suijten@somainline.org>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Mike Leach" <mike.leach@linaro.org>,
"Sam Ravnborg" <sam@ravnborg.org>, "Sean Paul" <sean@poorly.run>,
"Tom Rix" <trix@redhat.com>,
coresight@lists.linaro.org, devicetree@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-media@vger.kernel.org, linux-omap@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-sound@vger.kernel.org,
linux-staging@lists.linux.dev,
linux-stm32@st-md-mailman.stormreply.com,
linux-tegra@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH v3 05/24] media: i2c: switch to use of_graph_get_next_device_endpoint()
Date: Tue, 6 Feb 2024 02:06:02 +0000 [thread overview]
Message-ID: <87wmriny7q.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <875xz3n6ag.wl-kuninori.morimoto.gx@renesas.com>
Hi Rob, again
> > This is assuming there's just 1 port and 1 endpoint, but let's be
> > specific as the bindings are (first endpoint on port 0):
> >
> > of_graph_get_endpoint_by_regs(client->dev.of_node, 0, -1);
> >
> > Note we could ask for endpoint 0 here, but the bindings generally allow
> > for more than 1.
> >
> > I imagine most of the other cases here are the same.
I'm bit confused here.
You mentioned that -1 is wrong in previous mail.
Most cases are in the form of of_graph_get_next_endpoint(dev, NULL)
which is equivalent to of_graph_get_endpoint_by_regs(dev, 0, 0).
Technically, -1 instead of 0 is equivalent, but I'd argue is sloppy and
wrong.
But you mentioned -1 here, So, I will use it on next patch-set.
Thank you for your help !!
Best regards
---
Renesas Electronics
Ph.D. Kuninori Morimoto
next prev parent reply other threads:[~2024-02-06 2:06 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 5:04 [PATCH v3 00/24] of: property: add port base loop Kuninori Morimoto
2024-01-31 5:04 ` [PATCH v3 01/24] of: property: add missing kerneldoc for of_graph_get_endpoint_count() Kuninori Morimoto
2024-01-31 5:05 ` [PATCH v3 02/24] of: property: use unsigned int return on of_graph_get_endpoint_count() Kuninori Morimoto
2024-01-31 6:30 ` Dmitry Baryshkov
2024-02-01 0:12 ` Kuninori Morimoto
2024-01-31 5:05 ` [PATCH v3 03/24] of: property: rename of_graph_get_next_endpoint() to of_graph_get_next_device_endpoint() Kuninori Morimoto
2024-01-31 5:05 ` [PATCH v3 04/24] video: fbdev: switch to use of_graph_get_next_device_endpoint() Kuninori Morimoto
2024-01-31 5:05 ` [PATCH v3 05/24] media: i2c: " Kuninori Morimoto
2024-02-02 17:49 ` Rob Herring
2024-02-04 23:44 ` Kuninori Morimoto
2024-02-05 16:55 ` Rob Herring
2024-02-05 23:34 ` Kuninori Morimoto
2024-02-06 2:06 ` Kuninori Morimoto [this message]
2024-01-31 5:05 ` [PATCH v3 06/24] media: platform: " Kuninori Morimoto
2024-02-02 17:56 ` Rob Herring
2024-01-31 5:05 ` [PATCH v3 07/24] gpu: drm: " Kuninori Morimoto
2024-01-31 6:32 ` Dmitry Baryshkov
2024-01-31 5:05 ` [PATCH v3 08/24] hwtracing: " Kuninori Morimoto
2024-02-02 18:01 ` Suzuki K Poulose
2024-01-31 5:05 ` [PATCH v3 09/24] staging: " Kuninori Morimoto
2024-01-31 5:06 ` [PATCH v3 10/24] ASoC: " Kuninori Morimoto
2024-01-31 5:06 ` [PATCH v3 11/24] of: remove of_graph_get_next_endpoint() define Kuninori Morimoto
2024-01-31 5:06 ` [PATCH v3 12/24] of: property: add port base loop Kuninori Morimoto
2024-01-31 5:06 ` [PATCH v3 13/24] of: property: use of_graph_get_next_port() on of_graph_get_next_endpoint() Kuninori Morimoto
2024-01-31 5:06 ` [PATCH v3 14/24] of: property: add of_graph_get_next_endpoint() Kuninori Morimoto
2024-01-31 9:07 ` Luca Ceresoli
2024-01-31 23:26 ` Kuninori Morimoto
2024-01-31 5:06 ` [PATCH v3 15/24] drm: omapdrm: use of_graph_get_next_endpoint() Kuninori Morimoto
2024-01-31 5:06 ` [PATCH v3 16/24] media: xilinx-tpg: " Kuninori Morimoto
2024-01-31 5:06 ` [PATCH v3 17/24] ASoC: audio-graph-card: " Kuninori Morimoto
2024-01-31 5:07 ` [PATCH v3 18/24] ASoC: audio-graph-card2: use of_graph_get_next_port() Kuninori Morimoto
2024-01-31 5:07 ` [PATCH v3 19/24] ASoC: audio-graph-card2: use of_graph_get_next_endpoint() Kuninori Morimoto
2024-01-31 5:07 ` [PATCH v3 20/24] ASoC: test-component: use for_each_port_of_node() Kuninori Morimoto
2024-01-31 5:07 ` [PATCH v3 21/24] fbdev: omapfb: use of_graph_get_remote_port() Kuninori Morimoto
2024-01-31 5:07 ` [PATCH v3 22/24] fbdev: omapfb: use of_graph_get_next_port() Kuninori Morimoto
2024-01-31 5:07 ` [PATCH v3 23/24] fbdev: omapfb: use of_graph_get_next_endpoint() Kuninori Morimoto
2024-01-31 5:07 ` [PATCH v3 24/24] fbdev: omapfb: use of_graph_get_next_device_endpoint() Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmriny7q.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=abrodkin@synopsys.com \
--cc=agross@kernel.org \
--cc=airlied@gmail.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=andrzej.hajda@intel.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=broonie@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=coresight@lists.linaro.org \
--cc=daniel@ffwll.ch \
--cc=dave.stevenson@raspberrypi.com \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=eugen.hristev@collabora.com \
--cc=festevam@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=freedreno@lists.freedesktop.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hugues.fruchet@foss.st.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jacopo+renesas@jmondi.org \
--cc=jacopo.mondi@ideasonboard.com \
--cc=jacopo@jmondi.org \
--cc=james.clark@arm.com \
--cc=jbrunet@baylibre.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=jonathanh@nvidia.com \
--cc=khilman@baylibre.com \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=leo.yan@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=llvm@lists.linux.dev \
--cc=luca.ceresoli@bootlin.com \
--cc=m.tretter@pengutronix.de \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marex@denx.de \
--cc=marijn.suijten@somainline.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mchehab@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=michal.simek@amd.com \
--cc=mike.leach@linaro.org \
--cc=mripard@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=neil.armstrong@linaro.org \
--cc=nicolas.ferre@microchip.com \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=ojeda@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=perex@perex.cz \
--cc=philippe.cornu@foss.st.com \
--cc=prabhakar.csengg@gmail.com \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_jesszhan@quicinc.com \
--cc=raphael.gallais-pou@foss.st.com \
--cc=rfoss@kernel.org \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=s.nawrocki@samsung.com \
--cc=sakari.ailus@linux.intel.com \
--cc=sam@ravnborg.org \
--cc=saravanak@google.com \
--cc=sean@poorly.run \
--cc=shawnguo@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=stefan@agner.ch \
--cc=suzuki.poulose@arm.com \
--cc=tharvey@gateworks.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=todor.too@gmail.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=trix@redhat.com \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@pengutronix.de \
--cc=victor.liu@nxp.com \
--cc=yannick.fertre@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).