From: Dan Carpenter <dan.carpenter@linaro.org>
To: A <ashokemailat@yahoo.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy@lists.linux.dev
Subject: Re: [PATCH] staging:fbtft:fb_ili9320 Removed redundant Parentheses
Date: Mon, 22 Apr 2024 16:25:36 +0300 [thread overview]
Message-ID: <9baed766-a2d2-4b94-ae2b-d16ffbea3f67@moroto.mountain> (raw)
In-Reply-To: <452e4a2dcdc7020f75b84d787297a1d17a21ca81.camel@yahoo.com>
0) Fix your From address.
1) Look at how other people write subjects.
git log --oneline drivers/staging/fbtft/fb_ili9320.c
On Fri, Apr 19, 2024 at 11:04:21AM -0700, A wrote:
> >From 51e98164e314a2d1d834d2a9baea21a9823650bb Mon Sep 17 00:00:00 2001
> From: Ashok Kumar <ashokemailat@yahoo.com>
> Date: Fri, 19 Apr 2024 10:32:48 -0700
> Subject: [PATCH] staging:fbtft:fb_ili9320 Removed redundant
> Parentheses
2) This should not be part of the email.
>
> Adhere to Linux kernel coding style.
> Reported by checkpatch
>
> CHECK: Unnecessary parentheses around 'devcode != 0x0000'
> + if ((devcode != 0x0000) && (devcode != 0x9320))
>
3) Just leave this as-is. Ignore checkpatch in this case. Greg likes
parens.
> Signed-off-by: Ashok Kumar <ashokemailat@yahoo.com>
> ---
> drivers/staging/fbtft/fb_ili9320.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fb_ili9320.c
> b/drivers/staging/fbtft/fb_ili9320.c
> index 0be7c2d51548..409b54cc562e 100644
> --- a/drivers/staging/fbtft/fb_ili9320.c
> +++ b/drivers/staging/fbtft/fb_ili9320.c
> @@ -37,7 +37,7 @@ static int init_display(struct fbtft_par *par)
> devcode = read_devicecode(par);
> fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, "Device code:
> 0x%04X\n",
4) This patch is corrupt and will not apply. Read the first two
paragraphs of Documentation/process/email-clients.rst.
regards,
dan carpenter
prev parent reply other threads:[~2024-04-22 13:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <452e4a2dcdc7020f75b84d787297a1d17a21ca81.camel.ref@yahoo.com>
2024-04-19 18:04 ` [PATCH] staging:fbtft:fb_ili9320 Removed redundant Parentheses A
2024-04-22 13:25 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9baed766-a2d2-4b94-ae2b-d16ffbea3f67@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=ashokemailat@yahoo.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).