From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Thomas Zimmermann <tzimmermann@suse.de>,
"mpe@ellerman.id.au" <mpe@ellerman.id.au>,
"jani.nikula@intel.com" <jani.nikula@intel.com>,
"naresh.kamboju@linaro.org" <naresh.kamboju@linaro.org>,
"deller@gmx.de" <deller@gmx.de>,
"npiggin@gmail.com" <npiggin@gmail.com>,
"aneesh.kumar@kernel.org" <aneesh.kumar@kernel.org>,
"naveen.n.rao@linux.ibm.com" <naveen.n.rao@linux.ibm.com>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"lkft-triage@lists.linaro.org" <lkft-triage@lists.linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v2 3/3] arch/powerpc: Remove <linux/fb.h> from backlight code
Date: Tue, 5 Mar 2024 10:06:29 +0000 [thread overview]
Message-ID: <f10f4f22-0bec-4c0c-8b0f-3f68227dc9d0@csgroup.eu> (raw)
In-Reply-To: <f7503198-ab1b-463c-a8c8-9addbdcdab1b@suse.de>
Le 05/03/2024 à 11:04, Thomas Zimmermann a écrit :
> Hi
>
> Am 05.03.24 um 10:25 schrieb Christophe Leroy:
>>
>> Le 05/03/2024 à 10:01, Thomas Zimmermann a écrit :
>>> Replace <linux/fb.h> with a forward declaration in <asm/backlight.h> to
>>> resolves an unnecessary dependency. Remove pmac_backlight_curve_lookup()
>>> and struct fb_info from source and header files. The function and the
>>> framebuffer struct is unused. No functional changes.
>> When you remove pmac_backlight_curve_lookup() prototype you'll then get
>> a warning/error about missing prototype when building
>> arch/powerpc/platforms/powermac/backlight.c
>>
>> The fonction is not used outside of that file so it should be static.
>> And then it is not used in that file either so it should be removed
>> completely. Indeed last use of that function was removed by commit
>> d565dd3b0824 ("[PATCH] powerpc: More via-pmu backlight fixes") so the
>> function can safely be removed.
>
> Isn't that what my patch is doing? I have no callers of the function in
> my tree (drm-tip), so I removed it entirely. Should I add a Fixes tag
> against commit d565dd3b0824? Best regards Thomas
Sorry I overlooked your patch and focussed on the removal of the
prototype and missed the removal of the function.
Christophe
>>
>> Christophe
>>
>>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>>> ---
>>> arch/powerpc/include/asm/backlight.h | 5 ++--
>>> arch/powerpc/platforms/powermac/backlight.c | 26
>>> ---------------------
>>> 2 files changed, 2 insertions(+), 29 deletions(-)
>>>
>>> diff --git a/arch/powerpc/include/asm/backlight.h
>>> b/arch/powerpc/include/asm/backlight.h
>>> index 1b5eab62ed047..061a910d74929 100644
>>> --- a/arch/powerpc/include/asm/backlight.h
>>> +++ b/arch/powerpc/include/asm/backlight.h
>>> @@ -10,15 +10,14 @@
>>> #define __ASM_POWERPC_BACKLIGHT_H
>>> #ifdef __KERNEL__
>>> -#include <linux/fb.h>
>>> #include <linux/mutex.h>
>>> +struct backlight_device;
>>> +
>>> /* For locking instructions, see the implementation file */
>>> extern struct backlight_device *pmac_backlight;
>>> extern struct mutex pmac_backlight_mutex;
>>> -extern int pmac_backlight_curve_lookup(struct fb_info *info, int
>>> value);
>>> -
>>> extern int pmac_has_backlight_type(const char *type);
>>> extern void pmac_backlight_key(int direction);
>>> diff --git a/arch/powerpc/platforms/powermac/backlight.c
>>> b/arch/powerpc/platforms/powermac/backlight.c
>>> index aeb79a8b3e109..12bc01353bd3c 100644
>>> --- a/arch/powerpc/platforms/powermac/backlight.c
>>> +++ b/arch/powerpc/platforms/powermac/backlight.c
>>> @@ -9,7 +9,6 @@
>>> */
>>> #include <linux/kernel.h>
>>> -#include <linux/fb.h>
>>> #include <linux/backlight.h>
>>> #include <linux/adb.h>
>>> #include <linux/pmu.h>
>>> @@ -72,31 +71,6 @@ int pmac_has_backlight_type(const char *type)
>>> return 0;
>>> }
>>> -int pmac_backlight_curve_lookup(struct fb_info *info, int value)
>>> -{
>>> - int level = (FB_BACKLIGHT_LEVELS - 1);
>>> -
>>> - if (info && info->bl_dev) {
>>> - int i, max = 0;
>>> -
>>> - /* Look for biggest value */
>>> - for (i = 0; i < FB_BACKLIGHT_LEVELS; i++)
>>> - max = max((int)info->bl_curve[i], max);
>>> -
>>> - /* Look for nearest value */
>>> - for (i = 0; i < FB_BACKLIGHT_LEVELS; i++) {
>>> - int diff = abs(info->bl_curve[i] - value);
>>> - if (diff < max) {
>>> - max = diff;
>>> - level = i;
>>> - }
>>> - }
>>> -
>>> - }
>>> -
>>> - return level;
>>> -}
>>> -
>>> static void pmac_backlight_key_worker(struct work_struct *work)
>>> {
>>> if (atomic_read(&kernel_backlight_disabled))
>
prev parent reply other threads:[~2024-03-05 10:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 9:00 [PATCH v2 0/3] arch/powerpc: Resolve backlight include dependencies Thomas Zimmermann
2024-03-05 9:00 ` [PATCH v2 1/3] fbdev/chipsfb: Include <linux/backlight.h> Thomas Zimmermann
2024-03-05 9:00 ` [PATCH v2 2/3] macintosh/via-pmu-backlight: " Thomas Zimmermann
2024-03-05 9:13 ` Jani Nikula
2024-03-05 9:01 ` [PATCH v2 3/3] arch/powerpc: Remove <linux/fb.h> from backlight code Thomas Zimmermann
2024-03-05 9:15 ` Jani Nikula
2024-03-05 9:25 ` Christophe Leroy
2024-03-05 10:04 ` Thomas Zimmermann
2024-03-05 10:06 ` Christophe Leroy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f10f4f22-0bec-4c0c-8b0f-3f68227dc9d0@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=aneesh.kumar@kernel.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkft-triage@lists.linaro.org \
--cc=mpe@ellerman.id.au \
--cc=naresh.kamboju@linaro.org \
--cc=naveen.n.rao@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).