From: Shresth Prasad <shresthprasad7@gmail.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: daniel.thompson@linaro.org, deller@gmx.de,
dri-devel@lists.freedesktop.org, javier.carrasco.cruz@gmail.com,
jingoohan1@gmail.com, julia.lawall@inria.fr, lee@kernel.org,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org
Subject: Re: [PATCH][next] drivers: video: Simplify device_node cleanup using __free
Date: Sat, 20 Apr 2024 12:41:07 +0530 (GMT+05:30) [thread overview]
Message-ID: <fe7df45c-b61f-4e8a-a13f-1e6a85cf83bf@gmail.com> (raw)
In-Reply-To: <yelspf4hfmmj3lnk3exyc6tm2lrsqlet623q2s5zrm2unba6nw@43ewuqdzckdg>
20 Apr 2024 1:13:42 am Dmitry Baryshkov <dmitry.baryshkov@linaro.org>:
> On Sat, Apr 20, 2024 at 12:22:41AM +0530, Shresth Prasad wrote:
>>
>>> Please fix the subject line to be "backlight: <driver>: ...". I came
>>> very close to deleting this patch without reading it ;-) .
>>
>> Really sorry about that, I'll fix it.
>>
>>> Do we need to get dev->of_node at all? The device, which we are
>>> borrowing, already owns a reference to the node so I don't see
>>> any point in this function taking an extra one.
>>>
>>> So why not simply make this:
>>>
>>> struct device_node *np = dev->of_node;
>>
>> Looking at it again, I'm not sure why the call to `of_node_put` is there in the first place. I think removing it will be fine.
>>
>> I'll fix both of these issues and send a patch v2.
>
> Just a stupid quesiton: on which platform was this patch tested?
>
> --
> With best wishes
> Dmitry
I tested the patch on a x86_64 qemu virtual machine
Regards,
Shresth
prev parent reply other threads:[~2024-04-20 7:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 19:43 [PATCH][next] drivers: video: Simplify device_node cleanup using __free Shresth Prasad
2024-04-19 11:16 ` Daniel Thompson
2024-04-19 18:52 ` Shresth Prasad
2024-04-19 19:43 ` Dmitry Baryshkov
2024-04-20 7:11 ` Shresth Prasad [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe7df45c-b61f-4e8a-a13f-1e6a85cf83bf@gmail.com \
--to=shresthprasad7@gmail.com \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=julia.lawall@inria.fr \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).