* [PATCH] Remove of_node_put from drivers/video/fbdev/offb.c
@ 2024-05-02 20:00 Aryabhatta Dey
0 siblings, 0 replies; only message in thread
From: Aryabhatta Dey @ 2024-05-02 20:00 UTC (permalink / raw
To: linux-fbdev, dri-devel, linux-kernel
Cc: deller, tzimmermann, sam, christophe.jaillet,
javier.carrasco.cruz, skhan
Add __free(device_node) to the declaration of the pointer pointing to the pci
parent.
This change replaces the manual clean up done by of_node_put() with scope based
memory management.
Signed-off-by: Aryabhatta Dey <aryabhattadey35@gmail.com>
Suggested-by: Julia Lawall <julia.lawall@inria.fr>
---
drivers/video/fbdev/offb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c
index b421b46d88ef..ea38a260774b 100644
--- a/drivers/video/fbdev/offb.c
+++ b/drivers/video/fbdev/offb.c
@@ -357,7 +357,7 @@ static void offb_init_palette_hacks(struct fb_info *info, struct device_node *dp
par->cmap_type = cmap_gxt2000;
} else if (of_node_name_prefix(dp, "vga,Display-")) {
/* Look for AVIVO initialized by SLOF */
- struct device_node *pciparent = of_get_parent(dp);
+ struct device_node *pciparent __free(device_node) = of_get_parent(dp);
const u32 *vid, *did;
vid = of_get_property(pciparent, "vendor-id", NULL);
did = of_get_property(pciparent, "device-id", NULL);
@@ -369,7 +369,6 @@ static void offb_init_palette_hacks(struct fb_info *info, struct device_node *dp
if (par->cmap_adr)
par->cmap_type = cmap_avivo;
}
- of_node_put(pciparent);
} else if (dp && of_device_is_compatible(dp, "qemu,std-vga")) {
#ifdef __BIG_ENDIAN
const __be32 io_of_addr[3] = { 0x01000000, 0x0, 0x0 };
--
2.44.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2024-05-02 20:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-02 20:00 [PATCH] Remove of_node_put from drivers/video/fbdev/offb.c Aryabhatta Dey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).