From: "Colberg, Peter" <peter.colberg@intel.com>
To: "russ.weight@linux.dev" <russ.weight@linux.dev>,
"yilun.xu@linux.intel.com" <yilun.xu@linux.intel.com>
Cc: "Xu, Yilun" <yilun.xu@intel.com>,
"linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
"lee@kernel.org" <lee@kernel.org>,
"mdf@kernel.org" <mdf@kernel.org>, "Wu, Hao" <hao.wu@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Pagani, Marco" <marpagan@redhat.com>,
"russell.h.weight@intel.com" <russell.h.weight@intel.com>,
"Rix, Tom" <trix@redhat.com>,
"matthew.gerlach@linux.intel.com"
<matthew.gerlach@linux.intel.com>,
"ilpo.jarvinen@linux.intel.com" <ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH] mfd: intel-m10-bmc: Change staging size to a variable
Date: Tue, 2 Apr 2024 18:44:31 +0000 [thread overview]
Message-ID: <64f93fd3c7720b28adf4cffd562ed91da2a421f3.camel@intel.com> (raw)
In-Reply-To: <ZgurQETbga0Q/PVE@yilunxu-OptiPlex-7050>
On Tue, 2024-04-02 at 14:52 +0800, Xu Yilun wrote:
> On Mon, Apr 01, 2024 at 10:19:47AM -0700, Russ Weight wrote:
> >
> > On Mon, Apr 01, 2024 at 10:09:05AM -0700, Russ Weight wrote:
> > > On Mon, Apr 01, 2024 at 05:46:29PM +0800, Xu Yilun wrote:
> > > > On Thu, Mar 28, 2024 at 07:35:59PM -0400, Peter Colberg wrote:
> > > > > From: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > > > >
> > > > > The size of the staging area in FLASH for FPGA updates is dependent on the
> > > > > size of the FPGA. Currently, the staging size is defined as a constant.
> > > > > Larger FPGAs are coming soon and it will soon be necessary to support
> > > >
> > > > Soon? When? You cannot add some feature without a user case. If you do
> > > > have a use case, put the patch in the same patchset.
> > >
> > > There may never be an up-streamed use-case. This is a very small
> > > change intended to make it easier for a third-party vendor to
> > > build a card that requires a larger staging area in FLASH. They
> > > would have to add a new "struct m10bmc_csr_map", but they
> > > wouldn't have to refactor this code as part of the change
>
> I'm OK with this description.
>
> Peter, is that what you mean?
Yes.
> Or you do have a board type to follow, in
> which case you need to submit the new board type as well.
>
> > >
> > > This change does not introduce an unused function or variable.
> > > It is more of a clean-up, making the code more flexible.
> > >
> > > Can it not be taken as is?
> >
> > Would it be acceptable to just change the commit message to something
> > like:
> >
> > Do not hardwire the staging size in the secure update driver. Move
> > the staging size to the m10bmc_csr_map structure to make the size
> > assignment more flexible.
>
> That would be much better.
Thanks Russ, thanks Yilun, I will send a revised patch.
Peter
>
> Thanks,
> Yilun
prev parent reply other threads:[~2024-04-02 18:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 23:35 [PATCH] mfd: intel-m10-bmc: Change staging size to a variable Peter Colberg
2024-04-01 9:46 ` Xu Yilun
2024-04-01 17:09 ` Russ Weight
2024-04-01 17:19 ` Russ Weight
2024-04-02 6:52 ` Xu Yilun
2024-04-02 18:44 ` Colberg, Peter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64f93fd3c7720b28adf4cffd562ed91da2a421f3.camel@intel.com \
--to=peter.colberg@intel.com \
--cc=hao.wu@intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=lee@kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marpagan@redhat.com \
--cc=matthew.gerlach@linux.intel.com \
--cc=mdf@kernel.org \
--cc=russ.weight@linux.dev \
--cc=russell.h.weight@intel.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
--cc=yilun.xu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).