From: Xu Yilun <yilun.xu@intel.com>
To: Marco Pagani <marpagan@redhat.com>
Cc: Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
Tom Rix <trix@redhat.com>,
linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org
Subject: Re: [RFC PATCH v2 2/4] fpga: add fake FPGA bridge
Date: Sat, 25 Mar 2023 15:27:36 +0800 [thread overview]
Message-ID: <ZB6iaKEVnVfV3Atl@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <988e8e8e-d514-4c69-a384-7d0a70c514c4@redhat.com>
On 2023-03-21 at 18:33:05 +0100, Marco Pagani wrote:
>
>
> On 2023-03-17 09:32, Xu Yilun wrote:
> > On 2023-03-10 at 18:04:10 +0100, Marco Pagani wrote:
> >> Add fake FPGA bridge driver with support functions. The driver includes
> >> a counter for the number of switching cycles. This module is part of
> >> the KUnit tests for the FPGA subsystem.
> >>
> >> Signed-off-by: Marco Pagani <marpagan@redhat.com>
> >> ---
> >> drivers/fpga/tests/fake-fpga-bridge.c | 228 ++++++++++++++++++++++++++
> >> drivers/fpga/tests/fake-fpga-bridge.h | 36 ++++
> >> 2 files changed, 264 insertions(+)
> >> create mode 100644 drivers/fpga/tests/fake-fpga-bridge.c
> >> create mode 100644 drivers/fpga/tests/fake-fpga-bridge.h
> >>
> >> diff --git a/drivers/fpga/tests/fake-fpga-bridge.c b/drivers/fpga/tests/fake-fpga-bridge.c
> >> new file mode 100644
> >> index 000000000000..8a2f64fc1bbb
> >> --- /dev/null
> >> +++ b/drivers/fpga/tests/fake-fpga-bridge.c
> >> @@ -0,0 +1,228 @@
> >> +// SPDX-License-Identifier: GPL-2.0
> >> +/*
> >> + * Driver for the fake FPGA bridge
> >> + *
> >> + * Copyright (C) 2023 Red Hat, Inc.
> >> + *
> >> + * Author: Marco Pagani <marpagan@redhat.com>
> >> + */
> >> +
> >> +#include <linux/types.h>
> >> +#include <linux/device.h>
> >> +#include <linux/platform_device.h>
> >> +#include <linux/fpga/fpga-bridge.h>
> >> +#include <kunit/test.h>
> >> +
> >> +#include "fake-fpga-bridge.h"
> >> +
> >> +#define FAKE_FPGA_BRIDGE_DEV_NAME "fake_fpga_bridge"
> >> +
> >> +struct fake_bridge_priv {
> >> + int id;
> >> + bool enable;
> >> + int cycles_count;
> >> + struct kunit *test;
> >> +};
> >> +
> >> +struct fake_bridge_data {
> >> + struct kunit *test;
> >> +};
> >> +
> >> +static int op_enable_show(struct fpga_bridge *bridge)
> >> +{
> >> + struct fake_bridge_priv *priv;
> >> +
> >> + priv = bridge->priv;
> >> +
> >> + if (priv->test)
> >> + kunit_info(priv->test, "Fake FPGA bridge %d: enable_show\n",
> >> + priv->id);
> >
> > Why check the kunit pointer every time? I remember you mentioned that
> > the fake fpga modules are expected to be used out of Kunit test, so the
> > priv->test may be NULL? I suggest you work on these usecases in separate
> > patchsets. For now just check priv->test on probe is fine.
> >
>
> The idea was to provide additional info messages, tied with the test, if the
> fake bridge is registered with a test instance. If you believe these prints
> are unnecessary, I can remove them or replace them with generic dev_info().
OK, on second thought, it's good to me.
Thanks,
Yilun
next prev parent reply other threads:[~2023-03-25 7:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 17:04 [RFC PATCH v2 0/4] fpga: add initial KUnit tests for the subsystem Marco Pagani
2023-03-10 17:04 ` [RFC PATCH v2 1/4] fpga: add fake FPGA manager Marco Pagani
2023-03-10 17:04 ` [RFC PATCH v2 2/4] fpga: add fake FPGA bridge Marco Pagani
2023-03-17 8:32 ` Xu Yilun
2023-03-21 17:33 ` Marco Pagani
2023-03-25 7:27 ` Xu Yilun [this message]
2023-03-10 17:04 ` [RFC PATCH v2 3/4] fpga: add fake FPGA region Marco Pagani
2023-03-17 10:40 ` Xu Yilun
2023-03-21 20:07 ` Marco Pagani
2023-03-25 7:11 ` Xu Yilun
2023-03-10 17:04 ` [RFC PATCH v2 4/4] fpga: add initial KUnit test suites Marco Pagani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZB6iaKEVnVfV3Atl@yilunxu-OptiPlex-7050 \
--to=yilun.xu@intel.com \
--cc=hao.wu@intel.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marpagan@redhat.com \
--cc=mdf@kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).