From: Xu Yilun <yilun.xu@intel.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Wu Hao <hao.wu@intel.com>, Tom Rix <trix@redhat.com>,
Moritz Fischer <mdf@kernel.org>,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] fpga: dfl-fme: constify pointers to hwmon_channel_info
Date: Tue, 11 Apr 2023 13:57:00 +0000 [thread overview]
Message-ID: <ZDVnLDpnkycl+Uz8@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <0e41f48f-229d-389f-1dec-7230f13e1600@roeck-us.net>
On 2023-04-07 at 16:08:45 -0700, Guenter Roeck wrote:
> On 4/7/23 08:01, Krzysztof Kozlowski wrote:
> > Statically allocated array of pointed to hwmon_channel_info can be made
> > const for safety.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >
> > ---
> >
> > This depends on hwmon core patch:
> > https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski@linaro.org/
> >
> > Therefore I propose this should also go via hwmon tree.
>
> I am not going to apply patches for 10+ subsystems through the hwmon tree.
> This can only result in chaos. The dependent patch is available at
>
> git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-const
>
> or wait until after the next commit window to apply this patch.
OK, I could apply this patch to linux-fpga in next cycle.
Thanks,
Yilun
>
> Thanks,
> Guenter
>
> >
> > Cc: Jean Delvare <jdelvare@suse.com>
> > Cc: Guenter Roeck <linux@roeck-us.net>
> > Cc: linux-hwmon@vger.kernel.org
> > ---
> > drivers/fpga/dfl-fme-main.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/fpga/dfl-fme-main.c b/drivers/fpga/dfl-fme-main.c
> > index 77ea04d4edbe..bcb5d34b3b82 100644
> > --- a/drivers/fpga/dfl-fme-main.c
> > +++ b/drivers/fpga/dfl-fme-main.c
> > @@ -265,7 +265,7 @@ static const struct hwmon_ops thermal_hwmon_ops = {
> > .read = thermal_hwmon_read,
> > };
> > -static const struct hwmon_channel_info *thermal_hwmon_info[] = {
> > +static const struct hwmon_channel_info * const thermal_hwmon_info[] = {
> > HWMON_CHANNEL_INFO(temp, HWMON_T_INPUT | HWMON_T_EMERGENCY |
> > HWMON_T_MAX | HWMON_T_MAX_ALARM |
> > HWMON_T_CRIT | HWMON_T_CRIT_ALARM),
> > @@ -465,7 +465,7 @@ static const struct hwmon_ops power_hwmon_ops = {
> > .write = power_hwmon_write,
> > };
> > -static const struct hwmon_channel_info *power_hwmon_info[] = {
> > +static const struct hwmon_channel_info * const power_hwmon_info[] = {
> > HWMON_CHANNEL_INFO(power, HWMON_P_INPUT |
> > HWMON_P_MAX | HWMON_P_MAX_ALARM |
> > HWMON_P_CRIT | HWMON_P_CRIT_ALARM),
>
prev parent reply other threads:[~2023-04-11 5:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 15:01 [PATCH] fpga: dfl-fme: constify pointers to hwmon_channel_info Krzysztof Kozlowski
2023-04-07 16:24 ` Russ Weight
2023-04-07 23:08 ` Guenter Roeck
2023-04-11 13:57 ` Xu Yilun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDVnLDpnkycl+Uz8@yilunxu-OptiPlex-7050 \
--to=yilun.xu@intel.com \
--cc=hao.wu@intel.com \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mdf@kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).