From: Xu Yilun <yilun.xu@linux.intel.com>
To: "Colberg, Peter" <peter.colberg@intel.com>
Cc: lkp <lkp@intel.com>,
"enno.luebbers@intel.com" <enno.luebbers@intel.com>,
"Xu, Yilun" <yilun.xu@intel.com>,
"linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
"mdf@kernel.org" <mdf@kernel.org>,
"luwei.kang@intel.com" <luwei.kang@intel.com>,
"Wu, Hao" <hao.wu@intel.com>,
"atull@kernel.org" <atull@kernel.org>,
"shiva.rao@intel.com" <shiva.rao@intel.com>,
"russ.weight@linux.dev" <russ.weight@linux.dev>,
"Rix, Tom" <trix@redhat.com>,
"Pagani, Marco" <marpagan@redhat.com>,
"matthew.gerlach@linux.intel.com"
<matthew.gerlach@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] fpga: dfl: fme: revise kernel-doc comments for some functions
Date: Wed, 10 Apr 2024 13:05:50 +0800 [thread overview]
Message-ID: <ZhYeLvVJ49Bq1QCu@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <5106eb7c65599eca583f146bd18a5fd1836e9600.camel@intel.com>
On Tue, Apr 09, 2024 at 06:30:45PM +0000, Colberg, Peter wrote:
> On Tue, 2024-04-09 at 11:39 +0800, Xu Yilun wrote:
> > On Tue, Apr 02, 2024 at 04:47:43PM -0400, Peter Colberg wrote:
> > > From: Xu Yilun <yilun.xu@intel.com>
> > >
> > > This amends commit 782d8e61b5d6 ("fpga: dfl: kernel-doc corrections"),
> > > which separately addressed the kernel-doc warnings below. Add a more
> > > precise description of the feature argument to dfl_fme_create_mgr(),
> > > and also use plural in the description of dfl_fme_destroy_bridges().
> > >
> > > lkp reported 2 build warnings:
> > >
> > > drivers/fpga/dfl/dfl-fme-pr.c:175: warning: Function parameter or member 'feature' not described in 'dfl_fme_create_mgr'
> > >
> > > > > drivers/fpga/dfl/dfl-fme-pr.c:280: warning: expecting prototype for
> > > > > dfl_fme_destroy_bridge(). Prototype was for dfl_fme_destroy_bridges()
> > > > > instead
> >
> > Why still list the 2 warnings here? Do they still exsit even with commit
> > 782d8e61b5d6 ("fpga: dfl: kernel-doc corrections") ?
> >
> > >
> > > Fixes: 29de76240e86 ("fpga: dfl: fme: add partial reconfiguration sub feature support")
> >
> > You are still trying to fix this commit?
>
> I included the commit message from your original patch in full to show
> the initial motivation for the patch. As described, the issue has been
The out-of-date initial motivation, the commit 782d8e61b5d6, the listed
logs are not related to your change. It shouldn't appear in this patch.
Remember the commit message goes into git if the patch is merged. People
get confused about these information.
> addressed already; your patch merely polishes the the doc strings.
When you decide to submit a patch public, it is *YOUR* patch. You should
not list all the history and expect the original author decides what to
do.
>
> > I'm sorry, but please do check and test your patches before submit.
> > Re-submitting quickly but full of errors makes people doubt if you are
> > really serious about your patches. At least, I do have doubt if you did
> > tests for all your patches, or if your test could sufficiently prove the
> > issue exists or fixed.
>
> Apologies for sending the v1 patch, which had been rebased incorrectly.
This is not about the v1 patch, every new comer makes mistake. I just
don't like that you sent patches too quickly but didn't address the
previous concern.
Thanks,
Yilun
prev parent reply other threads:[~2024-04-10 5:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 20:47 [PATCH v2] fpga: dfl: fme: revise kernel-doc comments for some functions Peter Colberg
2024-04-09 3:39 ` Xu Yilun
2024-04-09 18:30 ` Colberg, Peter
2024-04-10 5:05 ` Xu Yilun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhYeLvVJ49Bq1QCu@yilunxu-OptiPlex-7050 \
--to=yilun.xu@linux.intel.com \
--cc=atull@kernel.org \
--cc=enno.luebbers@intel.com \
--cc=hao.wu@intel.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=luwei.kang@intel.com \
--cc=marpagan@redhat.com \
--cc=matthew.gerlach@linux.intel.com \
--cc=mdf@kernel.org \
--cc=peter.colberg@intel.com \
--cc=russ.weight@linux.dev \
--cc=shiva.rao@intel.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).